flake8
passed.
JSHint
passed.
Prevent visual jumps when editing the change description.
Review Request #12953 — Created April 13, 2023 and submitted
| Information | |
|---|---|
| david | |
| Review Board | |
| release-6.x | |
| Reviewers | |
| reviewboard | |
The line-height of the label for the change description field in the
unified banner wasn't enforcing a match between the text and the edit
icon, which meant that the UI would jump a few pixels when entering edit
mode (which hides the icon). Setting this explicitly makes it so things
don't reflow when that icon appears or disappears.
Entered/exited edit mode for the change description and saw that
everything stayed in one place.
| Summary | |
|---|---|
| Description | From | Last Updated |
|---|---|---|
|
Instead of magic numbering maybe we should define a @rb-icon-edit-height value in defs.less and use that here instead. |
 maubin
|
-
-
reviewboard/static/rb/css/ui/banners.less (Diff revision 1) Instead of magic numbering maybe we should define a
@rb-icon-edit-heightvalue in defs.less and use that here instead.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+16 -2) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
