Prevent visual jumps when editing the change description.

Review Request #12953 — Created April 13, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

The line-height of the label for the change description field in the
unified banner wasn't enforcing a match between the text and the edit
icon, which meant that the UI would jump a few pixels when entering edit
mode (which hides the icon). Setting this explicitly makes it so things
don't reflow when that icon appears or disappears.

Entered/exited edit mode for the change description and saw that
everything stayed in one place.

Summary ID
Prevent visual jumps when editing the change description.
The line-height of the label for the change description field in the unified banner wasn't enforcing a match between the text and the edit icon, which meant that the UI would jump a few pixels when entering edit mode (which hides the icon). Setting this explicitly makes it so things don't reflow when that icon appears or disappears. Testing Done: Entered/exited edit mode for the change description and saw that everything stayed in one place.
f09ded8dcddc93e97779b9f6809e685be6e4ba5f
Description From Last Updated

Instead of magic numbering maybe we should define a @rb-icon-edit-height value in defs.less and use that here instead.

maubinmaubin
maubin
  1. 
      
  2. Instead of magic numbering maybe we should define a @rb-icon-edit-height value in defs.less and use that here instead.

  3. 
      
david
maubin
  1. Ship It!
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (3b95deb)
Loading...