Prevent visual jumps when editing the change description.

Review Request #12953 — Created April 13, 2023 and submitted — Latest diff uploaded

Information

Review Board
release-6.x

Reviewers

The line-height of the label for the change description field in the
unified banner wasn't enforcing a match between the text and the edit
icon, which meant that the UI would jump a few pixels when entering edit
mode (which hides the icon). Setting this explicitly makes it so things
don't reflow when that icon appears or disappears.

Entered/exited edit mode for the change description and saw that
everything stayed in one place.

Diff Revision 1

This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

orig
1
2

Commits

First Last Summary ID Author
Prevent visual jumps when editing the change description.
The line-height of the label for the change description field in the unified banner wasn't enforcing a match between the text and the edit icon, which meant that the UI would jump a few pixels when entering edit mode (which hides the icon). Setting this explicitly makes it so things don't reflow when that icon appears or disappears. Testing Done: Entered/exited edit mode for the change description and saw that everything stayed in one place.
32a48f1e8771924033b18f15f24fcfe052825682 David Trowbridge
reviewboard/static/rb/css/ui/banners.less
Loading...