• 
      

    Add an error when attempting to publish a review of draft items.

    Review Request #12952 — Created April 12, 2023 and submitted — Latest diff uploaded

    Information

    Review Board
    release-6.x
    831

    Reviewers

    Now that reviews can exist with comments on draft, we want to prevent
    those reviews from being published. This change adds a check before we
    publish to verify that the review request itself is public, and checks
    for diff comments and file attachment comments to verify that the items
    being commented on are public.

    Ironically, we had a number of existing unit tests that were publishing
    reviews on draft items. These have been fixed up.

    Ran unit tests.

    Commits

    Files