Add an error when attempting to publish a review of draft items.

Review Request #12952 — Created April 12, 2023 and submitted

david
Review Board
release-6.x
831
reviewboard

Now that reviews can exist with comments on draft, we want to prevent
those reviews from being published. This change adds a check before we
publish to verify that the review request itself is public, and checks
for diff comments and file attachment comments to verify that the items
being commented on are public.

Ironically, we had a number of existing unit tests that were publishing
reviews on draft items. These have been fixed up.

Ran unit tests.

Summary
Add an error when attempting to publish a review of draft items.
Description From Last Updated

line too long (82 > 79 characters) Column: 80 Error code: E501

reviewbotreviewbot

line too long (81 > 79 characters) Column: 80 Error code: E501

reviewbotreviewbot

line too long (81 > 79 characters) Column: 80 Error code: E501

reviewbotreviewbot

line too long (80 > 79 characters) Column: 80 Error code: E501

reviewbotreviewbot
david
Review request changed

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

david
Review request changed

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

david
maubin
  1. 
      
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (e14e26c)
Loading...