Summary

Add an error when attempting to publish a review of draft items.

Review Request #12952 — Created April 12, 2023 and submitted April 25, 2023, 11:42 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

831

Depends On

Reviewers

Groups

reviewboard

People

Description

Ironically, we had a number of existing unit tests that were publishing
reviews on draft items. These have been fixed up.

Testing Done

Ran unit tests.

Commits

Summary	ID
Add an error when attempting to publish a review of draft items. Now that reviews can exist with comments on draft, we want to prevent those reviews from being published. This change adds a check before we publish to verify that the review request itself is public, and checks for diff comments and file attachment comments to verify that the items being commented on are public. Ironically, we had a number of existing unit tests that were publishing reviews on draft items. These have been fixed up. Testing Done: Ran unit tests. Bugs Fixed: 831	0732181e488371270066dcfafb1908ff20e2a074

Summary

Add an error when attempting to publish a review of draft items.

Now that reviews can exist with comments on draft, we want to prevent those reviews from being published. This change adds a check before we publish to verify that the review request itself is public, and checks for diff comments and file attachment comments to verify that the items being commented on are public. Ironically, we had a number of existing unit tests that were publishing reviews on draft items. These have been fixed up. Testing Done: Ran unit tests. Bugs Fixed: 831

0732181e488371270066dcfafb1908ff20e2a074

Issues

Description	From	Last Updated
line too long (82 > 79 characters) Column: 80 Error code: E501	reviewbot	April 13, 2023, 2:14 p.m.
line too long (81 > 79 characters) Column: 80 Error code: E501	reviewbot	April 13, 2023, 2:14 p.m.
line too long (81 > 79 characters) Column: 80 Error code: E501	reviewbot	April 13, 2023, 2:14 p.m.
line too long (80 > 79 characters) Column: 80 Error code: E501	reviewbot	April 13, 2023, 2:16 p.m.

flake8 passed.

JSHint passed.

Change Summary:

Add check step to batch publishing.

Commits:

	Summary	ID
	Add an error when attempting to publish a review of draft items. Now that reviews can exist with comments on draft, we want to prevent those reviews from being published. This change adds a check before we publish to verify that the review request itself is public, and checks for diff comments and file attachment comments to verify that the items being commented on are public. Ironically, we had a number of existing unit tests that were publishing reviews on draft items. These have been fixed up. Testing Done: Ran unit tests.	4d797c74f6c7ca20d0018a15143730fbc48007a1
	Add an error when attempting to publish a review of draft items. Now that reviews can exist with comments on draft, we want to prevent those reviews from being published. This change adds a check before we publish to verify that the review request itself is public, and checks for diff comments and file attachment comments to verify that the items being commented on are public. Ironically, we had a number of existing unit tests that were publishing reviews on draft items. These have been fixed up. Testing Done: Ran unit tests. Bugs Fixed: 831	4a99f3ff6d6e180e5c1a969f6a77d368107ee9a2

Bugs:

831

Diff:

Revision 2 (+364 -16)

Show changes

	reviewboard/notifications/tests/test_email_sending.py
	reviewboard/notifications/tests/test_webhooks.py
	reviewboard/reviews/models/diff_comment.py
	reviewboard/reviews/models/file_attachment_comment.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/tests/test_comment_diff_fragments_view.py
	reviewboard/reviews/tests/test_entries.py
	reviewboard/reviews/tests/test_review.py
	1 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/models/review.py (Diff revision 2)
The issue has been dropped. Show all issues
```
line too long (82 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/reviews/models/review.py (Diff revision 2)
The issue has been dropped. Show all issues
```
line too long (81 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/reviews/models/review.py (Diff revision 2)
The issue has been dropped. Show all issues
```
line too long (81 > 79 characters)

Column: 80
Error code: E501
```

Commits:

	Summary	ID
	Add an error when attempting to publish a review of draft items. Now that reviews can exist with comments on draft, we want to prevent those reviews from being published. This change adds a check before we publish to verify that the review request itself is public, and checks for diff comments and file attachment comments to verify that the items being commented on are public. Ironically, we had a number of existing unit tests that were publishing reviews on draft items. These have been fixed up. Testing Done: Ran unit tests. Bugs Fixed: 831	4a99f3ff6d6e180e5c1a969f6a77d368107ee9a2
	Add an error when attempting to publish a review of draft items. Now that reviews can exist with comments on draft, we want to prevent those reviews from being published. This change adds a check before we publish to verify that the review request itself is public, and checks for diff comments and file attachment comments to verify that the items being commented on are public. Ironically, we had a number of existing unit tests that were publishing reviews on draft items. These have been fixed up. Testing Done: Ran unit tests. Bugs Fixed: 831	0d37a75e73177fae3793451d620bf65ce9db5ffc

Diff:

Revision 3 (+364 -16)

Show changes

	reviewboard/notifications/tests/test_email_sending.py
	reviewboard/notifications/tests/test_webhooks.py
	reviewboard/reviews/models/diff_comment.py
	reviewboard/reviews/models/file_attachment_comment.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/tests/test_comment_diff_fragments_view.py
	reviewboard/reviews/tests/test_entries.py
	reviewboard/reviews/tests/test_review.py
	1 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/models/review.py (Diff revision 3)
The issue has been dropped. Show all issues
```
line too long (80 > 79 characters)

Column: 80
Error code: E501
```

Commits:

	Summary	ID
	Add an error when attempting to publish a review of draft items. Now that reviews can exist with comments on draft, we want to prevent those reviews from being published. This change adds a check before we publish to verify that the review request itself is public, and checks for diff comments and file attachment comments to verify that the items being commented on are public. Ironically, we had a number of existing unit tests that were publishing reviews on draft items. These have been fixed up. Testing Done: Ran unit tests. Bugs Fixed: 831	0d37a75e73177fae3793451d620bf65ce9db5ffc
	Add an error when attempting to publish a review of draft items. Now that reviews can exist with comments on draft, we want to prevent those reviews from being published. This change adds a check before we publish to verify that the review request itself is public, and checks for diff comments and file attachment comments to verify that the items being commented on are public. Ironically, we had a number of existing unit tests that were publishing reviews on draft items. These have been fixed up. Testing Done: Ran unit tests. Bugs Fixed: 831	0732181e488371270066dcfafb1908ff20e2a074

Diff:

Revision 4 (+366 -16)

Show changes

	reviewboard/notifications/tests/test_email_sending.py
	reviewboard/notifications/tests/test_webhooks.py
	reviewboard/reviews/models/diff_comment.py
	reviewboard/reviews/models/file_attachment_comment.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/tests/test_comment_diff_fragments_view.py
	reviewboard/reviews/tests/test_entries.py
	reviewboard/reviews/tests/test_review.py
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

Status:: Completed
Change Summary:: Pushed to release-6.x (e14e26c)