Add an error when attempting to publish a review of draft items.
Review Request #12952 — Created April 12, 2023 and submitted
Information | |
---|---|
david | |
Review Board | |
release-6.x | |
831 | |
Reviewers | |
reviewboard | |
Now that reviews can exist with comments on draft, we want to prevent
those reviews from being published. This change adds a check before we
publish to verify that the review request itself is public, and checks
for diff comments and file attachment comments to verify that the items
being commented on are public.Ironically, we had a number of existing unit tests that were publishing
reviews on draft items. These have been fixed up.
Ran unit tests.
Summary | |
---|---|
Description | From | Last Updated |
---|---|---|
line too long (82 > 79 characters) Column: 80 Error code: E501 |
![]() |
|
line too long (81 > 79 characters) Column: 80 Error code: E501 |
![]() |
|
line too long (81 > 79 characters) Column: 80 Error code: E501 |
![]() |
|
line too long (80 > 79 characters) Column: 80 Error code: E501 |
![]() |
Change Summary:
Add check step to batch publishing.
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Bugs: |
|
|||||||||
Diff: |
Revision 2 (+364 -16) |
Checks run (1 failed, 1 succeeded)
flake8
-
reviewboard/reviews/models/review.py (Diff revision 2) Show all issues -
reviewboard/reviews/models/review.py (Diff revision 2) line too long (81 > 79 characters) Column: 80 Error code: E501
-
reviewboard/reviews/models/review.py (Diff revision 2) line too long (81 > 79 characters) Column: 80 Error code: E501
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+364 -16) |
Checks run (1 failed, 1 succeeded)
flake8
-
reviewboard/reviews/models/review.py (Diff revision 3) line too long (80 > 79 characters) Column: 80 Error code: E501
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+366 -16) |