flake8
-
reviewboard/diffviewer/tests/test_diffutils.py (Diff revision 1) Show all issues
Review Request #12949 — Created April 12, 2023 and submitted
Information | |
---|---|
david | |
Review Board | |
release-6.x | |
Reviewers | |
reviewboard | |
For as long as Review Board has existed, we've disallowed commenting on
items before they're published. The reasoning here was that if you add a
diff comment, replacing the diff will delete the comment (and similar
for file attachments).This change updates the comment dialog to remove the
hasDraft
checks.
This is replaced with a new mechanism whereby we add apublic
state to
diffs and file attachments, and use that to show a warning to the user
if they're commenting on something which has not yet been published. The
bulk of the code changes here are just plumbing that state all the way
down to the comment block models, which use it to decide what to display
to the user.
Summary | |
---|---|
Description | From | Last Updated |
---|---|---|
Do comments get deleted when the draft diff/file is replaced? I think we should update the unit tests to confirm … |
![]() |
|
line too long (80 > 79 characters) Column: 80 Error code: E501 |
![]() |
|
If comments get deleted when a draft diff is replaced, I think we should explicitely say delete here instead of … |
![]() |
|
If comments get deleted when the file is replaced, I think we should explicitely say delete here instead of invalidate. |
![]() |
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+454 -44) |
Do comments get deleted when the draft diff/file is replaced? I think we should update the unit tests to confirm what happens after draft diffs/files get deleted while they have comments.
reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.es6.js (Diff revision 2) |
---|
If comments get deleted when a draft diff is replaced, I think we should explicitely say
delete
here instead ofinvalidate
.
reviewboard/static/rb/js/models/fileAttachmentCommentBlockModel.es6.js (Diff revision 2) |
---|
If comments get deleted when the file is replaced, I think we should explicitely say
delete
here instead ofinvalidate
.
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+538 -48) |