flake8
passed.
JSHint
passed.
Review Request #12948 — Created April 12, 2023 and submitted
Information | |
---|---|
david | |
Review Board | |
release-6.x | |
Reviewers | |
reviewboard | |
This change ports the CommentEditor model and associated tests to spina
and TypeScript.
reviewboard/static/rb/js/reviews/models/commentEditorModel.ts (Diff revision 1) |
---|
Missing a doc comment for the interface.
reviewboard/static/rb/js/reviews/models/commentEditorModel.ts (Diff revision 1) |
---|
This can probably be one line, if we want.
reviewboard/static/rb/js/reviews/models/commentEditorModel.ts (Diff revision 1) |
---|
Let's update these to use
listenTo()
instead of.on()
.Same below.
reviewboard/static/rb/js/reviews/models/commentEditorModel.ts (Diff revision 1) |
---|
This can be
stopListening()
.
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+338 -260) |