Port CommentEditor to spina

Review Request #12948 — Created April 12, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

This change ports the CommentEditor model and associated tests to spina
and TypeScript.

  • Ran js-tests.
  • Used the comment dialog.
Summary ID
Port CommentEditor to spina
This change ports the CommentEditor model and associated tests to spina and TypeScript. Testing Done: - Ran js-tests. - Used the comment dialog.
2f463303334b42f9633d90b45b90c6f2b796e1d6
Description From Last Updated

Missing a doc comment for the interface.

chipx86chipx86

This can probably be one line, if we want.

chipx86chipx86

Let's update these to use listenTo() instead of .on(). Same below.

chipx86chipx86

This can be stopListening().

chipx86chipx86

Two blank lines.

chipx86chipx86
chipx86
  1. 
      
  2. Missing a doc comment for the interface.

  3. This can probably be one line, if we want.

  4. Let's update these to use listenTo() instead of .on().

    Same below.

  5. This can be stopListening().

  6. Two blank lines.

  7. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (791da67)
Loading...