Summary

Port CommentEditor to spina

Review Request #12948 — Created April 12, 2023 and submitted April 25, 2023, 11:42 a.m.

Owner

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Groups

People

Description

This change ports the CommentEditor model and associated tests to spina
and TypeScript.

Testing Done


Ran js-tests.
Used the comment dialog.

Commits

Summary	ID
Port CommentEditor to spina This change ports the CommentEditor model and associated tests to spina and TypeScript. Testing Done: - Ran js-tests. - Used the comment dialog.	2f463303334b42f9633d90b45b90c6f2b796e1d6

Issues

Description	From	Last Updated
Missing a doc comment for the interface.	chipx86	April 18, 2023, 1:29 p.m.
This can probably be one line, if we want.	chipx86	April 18, 2023, 1:29 p.m.
Let's update these to use listenTo() instead of .on(). Same below.	chipx86	April 18, 2023, 1:31 p.m.
This can be stopListening().	chipx86	April 18, 2023, 1:32 p.m.
Two blank lines.	chipx86	April 18, 2023, 1:32 p.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/reviews/models/commentEditorModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing a doc comment for the interface.
```

reviewboard/static/rb/js/reviews/models/commentEditorModel.ts (Diff revision 1)

The issue has been resolved. Show all issues

This can probably be one line, if we want.

reviewboard/static/rb/js/reviews/models/commentEditorModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Let's update these to use listenTo() instead of .on().
Same below.
```
reviewboard/static/rb/js/reviews/models/commentEditorModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
This can be stopListening().
```
reviewboard/static/rb/js/reviews/views/commentDialogView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Two blank lines.
```

Commits:

	Summary	ID
	Port CommentEditor to spina This change ports the CommentEditor model and associated tests to spina and TypeScript. Testing Done: - Ran js-tests. - Used the comment dialog.	5debe4530ce757b0e45b82c5bfa6087d88071c07
	Port CommentEditor to spina This change ports the CommentEditor model and associated tests to spina and TypeScript. Testing Done: - Ran js-tests. - Used the comment dialog.	2f463303334b42f9633d90b45b90c6f2b796e1d6

Diff:

Revision 2 (+338 -260)

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/reviews/index.ts
	reviewboard/static/rb/js/models/commentEditorModel.es6.js
	reviewboard/static/rb/js/models/tests/commentEditorModelTests.es6.js
	reviewboard/static/rb/js/reviews/models/tests/index.ts
	reviewboard/static/rb/js/reviews/views/commentDialogView.ts
	reviewboard/static/rb/js/reviews/views/tests/commentDialogViewTests.ts

flake8 passed.

JSHint passed.

Ship it!