flake8
passed.
JSHint
passed.
Port CommentDialogView to spina.
Review Request #12947 — Created April 12, 2023 and submitted
| Information | |
|---|---|
| david | |
| Review Board | |
| release-6.x | |
| Reviewers | |
| reviewboard | |
This change ports the CommentDialogView and associated tests to spina
and TypeScript.
- Ran js-tests.
- Used the comment dialog.
Change Summary:
Fix up one missing conversion from
_to#.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+952 -934) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
-
reviewboard/static/rb/js/reviews/views/commentDialogView.ts (Diff revision 2) Missing a doc comment.
-
-
-
-
reviewboard/static/rb/js/reviews/views/commentDialogView.ts (Diff revision 2) Can we group together the public ones, and document at least those?
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+1008 -934) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.