Port CommentDialogView to spina.

Review Request #12947 — Created April 12, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

This change ports the CommentDialogView and associated tests to spina
and TypeScript.

  • Ran js-tests.
  • Used the comment dialog.
Summary ID
Port CommentDialogView to spina.
This change ports the CommentDialogView and associated tests to spina and TypeScript. Testing Done: - Ran js-tests. - Used the comment dialog.
4c9c2fd8ae63c274c9ef2e7bcb03f217cf9b6623
Description From Last Updated

Two blank lines.

chipx86chipx86

Missing a doc comment.

chipx86chipx86

Missing docs.

chipx86chipx86

Missing docs.

chipx86chipx86

Missing docs.

chipx86chipx86

Can we group together the public ones, and document at least those?

chipx86chipx86
david
chipx86
  1. 
      
  2. Two blank lines.

  3. Missing a doc comment.

  4. reviewboard/static/rb/js/reviews/views/commentDialogView.ts (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    Can we group together the public ones, and document at least those?

  5. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (05e9638)
Loading...