Summary

Port CommentDialogView to spina.

Review Request #12947 — Created April 12, 2023 and submitted April 25, 2023, 11:42 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change ports the CommentDialogView and associated tests to spina
and TypeScript.

Testing Done


Ran js-tests.
Used the comment dialog.

Commits

Summary	ID
Port CommentDialogView to spina. This change ports the CommentDialogView and associated tests to spina and TypeScript. Testing Done: - Ran js-tests. - Used the comment dialog.	4c9c2fd8ae63c274c9ef2e7bcb03f217cf9b6623

Issues

Description	From	Last Updated
Two blank lines.	chipx86	April 18, 2023, 1:21 p.m.
Missing a doc comment.	chipx86	April 18, 2023, 1:21 p.m.
Missing docs.	chipx86	April 18, 2023, 1:21 p.m.
Missing docs.	chipx86	April 18, 2023, 1:21 p.m.
Missing docs.	chipx86	April 18, 2023, 1:21 p.m.
Can we group together the public ones, and document at least those?	chipx86	April 18, 2023, 1:23 p.m.

flake8 passed.

JSHint passed.

Change Summary:

Fix up one missing conversion from _ to #.

Commits:

	Summary	ID
	Port CommentDialogView to spina. This change ports the CommentDialogView and associated tests to spina and TypeScript. Testing Done: - Ran js-tests. - Used the comment dialog.	8843ff9de962a01d5344a653aeecaa32c5eefb5e
	Port CommentDialogView to spina. This change ports the CommentDialogView and associated tests to spina and TypeScript. Testing Done: - Ran js-tests. - Used the comment dialog.	042357305d5403543f04c776b65b947528d60659

Diff:

Revision 2 (+952 -934)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/reviews/index.ts
	reviewboard/static/rb/js/views/commentDialogView.es6.js
	reviewboard/static/rb/js/views/tests/commentDialogViewTests.es6.js
	reviewboard/static/rb/js/reviews/views/tests/index.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/reviews/views/commentDialogView.ts (Diff revision 2)
The issue has been resolved. Show all issues
```
Two blank lines.
```
reviewboard/static/rb/js/reviews/views/commentDialogView.ts (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing a doc comment.
```
reviewboard/static/rb/js/reviews/views/commentDialogView.ts (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing docs.
```
reviewboard/static/rb/js/reviews/views/commentDialogView.ts (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing docs.
```
reviewboard/static/rb/js/reviews/views/commentDialogView.ts (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing docs.
```

reviewboard/static/rb/js/reviews/views/commentDialogView.ts (Diff revision 2)

The issue has been resolved. Show all issues

Can we group together the public ones, and document at least those?

Commits:

	Summary	ID
	Port CommentDialogView to spina. This change ports the CommentDialogView and associated tests to spina and TypeScript. Testing Done: - Ran js-tests. - Used the comment dialog.	042357305d5403543f04c776b65b947528d60659
	Port CommentDialogView to spina. This change ports the CommentDialogView and associated tests to spina and TypeScript. Testing Done: - Ran js-tests. - Used the comment dialog.	4c9c2fd8ae63c274c9ef2e7bcb03f217cf9b6623

Diff:

Revision 3 (+1008 -934)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/reviews/index.ts
	reviewboard/static/rb/js/views/commentDialogView.es6.js
	reviewboard/static/rb/js/views/tests/commentDialogViewTests.es6.js
	reviewboard/static/rb/js/reviews/views/tests/index.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (05e9638)