Summary

Fix API issues creating comments on draft diffs.

Review Request #12946 — Created April 12, 2023 and submitted April 20, 2023, 8:04 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change fixes up a few issues with the API making comments on
not-yet-published diffs. The main problem here is that the DiffSet is not
added to the review request's DiffSetHistory until it is published. This
change fixes up the queries for both get_queryset and create to
handle this.

Testing Done


Ran unit tests.
Added some comments to a diff that was not yet published.

Commits

Summary	ID
Fix API issues creating comments on draft diffs. This change fixes up a few issues with the API making comments on not-yet-published diffs. The main problem here is that the DiffSet is not added to the review request's DiffSetHistory until it is published. This change fixes up the queries for both `get_queryset` and `create` to handle this. Testing Done: - Ran unit tests. - Added some comments to a diff that was not yet published.	d9877780a65c0e2cad0bfc4755cd8063087fe0f8

Summary

Fix API issues creating comments on draft diffs.

This change fixes up a few issues with the API making comments on not-yet-published diffs. The main problem here is that the DiffSet is not added to the review request's DiffSetHistory until it is published. This change fixes up the queries for both `get_queryset` and `create` to handle this. Testing Done: - Ran unit tests. - Added some comments to a diff that was not yet published.

d9877780a65c0e2cad0bfc4755cd8063087fe0f8

Issues

Description	From	Last Updated
line too long (90 > 79 characters) Column: 80 Error code: E501	reviewbot	April 12, 2023, 8:59 a.m.
line too long (80 > 79 characters) Column: 80 Error code: E501	reviewbot	April 12, 2023, 8:59 a.m.
unexpected spaces around keyword / parameter equals Column: 75 Error code: E251	reviewbot	April 12, 2023, 9:02 a.m.
continuation line over-indented for visual indent Column: 23 Error code: E127	reviewbot	April 12, 2023, 9:02 a.m.
unexpected spaces around keyword / parameter equals Column: 65 Error code: E251	reviewbot	April 12, 2023, 9:02 a.m.
continuation line over-indented for visual indent Column: 23 Error code: E127	reviewbot	April 12, 2023, 9:02 a.m.
line too long (90 > 79 characters) Column: 80 Error code: E501	reviewbot	April 12, 2023, 9:03 a.m.
line too long (80 > 79 characters) Column: 80 Error code: E501	reviewbot	April 12, 2023, 9:03 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/resources/base_diff_comment.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (90 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/webapi/resources/review_diff_comment.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (80 > 79 characters)

Column: 80
Error code: E501
```

Commits:

	Summary	ID
	Fix API issues creating comments on draft diffs. This change fixes up a few issues with the API making comments on not-yet-published diffs. The main problem here is that the DiffSet is not added to the review request's DiffSetHistory until it is published. This change fixes up the queries for both `get_queryset` and `create` to handle this. Testing Done: - Ran unit tests. - Added some comments to a diff that was not yet published.	3ca1d13bc3d529a72a9cc24dcbeb87d2fb15752c
	Fix API issues creating comments on draft diffs. This change fixes up a few issues with the API making comments on not-yet-published diffs. The main problem here is that the DiffSet is not added to the review request's DiffSetHistory until it is published. This change fixes up the queries for both `get_queryset` and `create` to handle this. Testing Done: - Ran unit tests. - Added some comments to a diff that was not yet published.	6635e72ddde6c85fa7a3bee4e7d46c7055e52ae4

Diff:

Revision 2 (+74 -8)

Show changes

	reviewboard/webapi/resources/base_diff_comment.py
	reviewboard/webapi/resources/review_diff_comment.py
	reviewboard/webapi/tests/test_review_comment.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/resources/base_diff_comment.py (Diff revision 2)
The issue has been dropped. Show all issues
```
unexpected spaces around keyword / parameter equals

Column: 75
Error code: E251
```
reviewboard/webapi/resources/base_diff_comment.py (Diff revision 2)
The issue has been dropped. Show all issues
```
continuation line over-indented for visual indent

Column: 23
Error code: E127
```
reviewboard/webapi/resources/review_diff_comment.py (Diff revision 2)
The issue has been dropped. Show all issues
```
unexpected spaces around keyword / parameter equals

Column: 65
Error code: E251
```
reviewboard/webapi/resources/review_diff_comment.py (Diff revision 2)
The issue has been dropped. Show all issues
```
continuation line over-indented for visual indent

Column: 23
Error code: E127
```

Commits:

	Summary	ID
	Fix API issues creating comments on draft diffs. This change fixes up a few issues with the API making comments on not-yet-published diffs. The main problem here is that the DiffSet is not added to the review request's DiffSetHistory until it is published. This change fixes up the queries for both `get_queryset` and `create` to handle this. Testing Done: - Ran unit tests. - Added some comments to a diff that was not yet published.	6635e72ddde6c85fa7a3bee4e7d46c7055e52ae4
	Fix API issues creating comments on draft diffs. This change fixes up a few issues with the API making comments on not-yet-published diffs. The main problem here is that the DiffSet is not added to the review request's DiffSetHistory until it is published. This change fixes up the queries for both `get_queryset` and `create` to handle this. Testing Done: - Ran unit tests. - Added some comments to a diff that was not yet published.	d9877780a65c0e2cad0bfc4755cd8063087fe0f8

Diff:

Revision 3 (+70 -8)

Show changes

	reviewboard/webapi/resources/base_diff_comment.py
	reviewboard/webapi/resources/review_diff_comment.py
	reviewboard/webapi/tests/test_review_comment.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/resources/base_diff_comment.py (Diff revision 3)
The issue has been dropped. Show all issues
```
line too long (90 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/webapi/resources/review_diff_comment.py (Diff revision 3)
The issue has been dropped. Show all issues
```
line too long (80 > 79 characters)

Column: 80
Error code: E501
```

Ship it!

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (8a7ca94)