Fix API issues creating comments on draft diffs.

Review Request #12946 — Created April 12, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

This change fixes up a few issues with the API making comments on
not-yet-published diffs. The main problem here is that the DiffSet is not
added to the review request's DiffSetHistory until it is published. This
change fixes up the queries for both get_queryset and create to
handle this.

  • Ran unit tests.
  • Added some comments to a diff that was not yet published.
Summary ID
Fix API issues creating comments on draft diffs.
This change fixes up a few issues with the API making comments on not-yet-published diffs. The main problem here is that the DiffSet is not added to the review request's DiffSetHistory until it is published. This change fixes up the queries for both `get_queryset` and `create` to handle this. Testing Done: - Ran unit tests. - Added some comments to a diff that was not yet published.
d9877780a65c0e2cad0bfc4755cd8063087fe0f8
Description From Last Updated

line too long (90 > 79 characters) Column: 80 Error code: E501

reviewbotreviewbot

line too long (80 > 79 characters) Column: 80 Error code: E501

reviewbotreviewbot

unexpected spaces around keyword / parameter equals Column: 75 Error code: E251

reviewbotreviewbot

continuation line over-indented for visual indent Column: 23 Error code: E127

reviewbotreviewbot

unexpected spaces around keyword / parameter equals Column: 65 Error code: E251

reviewbotreviewbot

continuation line over-indented for visual indent Column: 23 Error code: E127

reviewbotreviewbot

line too long (90 > 79 characters) Column: 80 Error code: E501

reviewbotreviewbot

line too long (80 > 79 characters) Column: 80 Error code: E501

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

david
Review request changed
Commits:
Summary ID
Fix API issues creating comments on draft diffs.
This change fixes up a few issues with the API making comments on not-yet-published diffs. The main problem here is that the DiffSet is not added to the review request's DiffSetHistory until it is published. This change fixes up the queries for both `get_queryset` and `create` to handle this. Testing Done: - Ran unit tests. - Added some comments to a diff that was not yet published.
3ca1d13bc3d529a72a9cc24dcbeb87d2fb15752c
Fix API issues creating comments on draft diffs.
This change fixes up a few issues with the API making comments on not-yet-published diffs. The main problem here is that the DiffSet is not added to the review request's DiffSetHistory until it is published. This change fixes up the queries for both `get_queryset` and `create` to handle this. Testing Done: - Ran unit tests. - Added some comments to a diff that was not yet published.
6635e72ddde6c85fa7a3bee4e7d46c7055e52ae4

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

david
Review request changed
Commits:
Summary ID
Fix API issues creating comments on draft diffs.
This change fixes up a few issues with the API making comments on not-yet-published diffs. The main problem here is that the DiffSet is not added to the review request's DiffSetHistory until it is published. This change fixes up the queries for both `get_queryset` and `create` to handle this. Testing Done: - Ran unit tests. - Added some comments to a diff that was not yet published.
6635e72ddde6c85fa7a3bee4e7d46c7055e52ae4
Fix API issues creating comments on draft diffs.
This change fixes up a few issues with the API making comments on not-yet-published diffs. The main problem here is that the DiffSet is not added to the review request's DiffSetHistory until it is published. This change fixes up the queries for both `get_queryset` and `create` to handle this. Testing Done: - Ran unit tests. - Added some comments to a diff that was not yet published.
d9877780a65c0e2cad0bfc4755cd8063087fe0f8

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

maubin
  1. 
      
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-6.x (8a7ca94)