Summary

Fix API issues creating comments on draft diffs.

Review Request #12943 — Created April 10, 2023 and discarded April 12, 2023, 9:05 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change fixes up a few issues with the API making comments on
not-yet-published diffs. The main problem here is that the DiffSet is not
added to the review request's DiffSetHistory until it is published. This
change fixes up the queries for both get_queryset and create to
handle this.

Testing Done


Ran unit tests.
Added some comments to a diff that was not yet published.

Commits

Summary	ID
Fix API issues creating comments on draft diffs. This change fixes up a few issues with the API making comments on not-yet-published diffs. The main problem here is that the DiffSet is not added to the review request's DiffSetHistory until it is published. This change fixes up the queries for both `get_queryset` and `create` to handle this. Testing Done: - Ran unit tests. - Added some comments to a diff that was not yet published.	e27af172ec676942927b4740e6f60c676f3e1a93

Summary

Fix API issues creating comments on draft diffs.

This change fixes up a few issues with the API making comments on not-yet-published diffs. The main problem here is that the DiffSet is not added to the review request's DiffSetHistory until it is published. This change fixes up the queries for both `get_queryset` and `create` to handle this. Testing Done: - Ran unit tests. - Added some comments to a diff that was not yet published.

e27af172ec676942927b4740e6f60c676f3e1a93

Issues

Description	From	Last Updated
line too long (90 > 79 characters) Column: 80 Error code: E501	reviewbot	April 10, 2023, 9:09 a.m.
line too long (80 > 79 characters) Column: 80 Error code: E501	reviewbot	April 10, 2023, 9:09 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/resources/base_diff_comment.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (90 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/webapi/resources/review_diff_comment.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (80 > 79 characters)

Column: 80
Error code: E501
```

Review Board 7.0 alpha 0 (dev)

Fix API issues creating comments on draft diffs.

Information

Reviewers

flake8

Status: Discarded