This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-6.x (222f92c)

Summary

Port DiffViewerPage and DiffViewerPageView to spina.

Review Request #12940 — Created April 5, 2023 and submitted 2 years ago — Latest diff uploaded 2 years ago

Information

Owner

david*

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description*

This change ports the diffviewer page model and view to spina. These
files have been moved into the reviews subdirectory to correspond to
the bundle they're a part of.

Testing Done


Ran js-tests.
Tested the diffviewer page.

Changes between revision 2 and 3

orig

Commits

	Summary	ID	Author
	Port DiffViewerPage and DiffViewerPageView to spina. This change ports the diffviewer page model and view to spina. These files have been moved into the `reviews` subdirectory to correspond to the bundle they're a part of. Testing Done: - Ran js-tests. - Tested the diffviewer page.	3a54662e7ce68c062ec29df60d2ad18c4083567e	David Trowbridge
	Port DiffViewerPage and DiffViewerPageView to spina. This change ports the diffviewer page model and view to spina. These files have been moved into the `reviews` subdirectory to correspond to the bundle they're a part of. Testing Done: - Ran js-tests. - Tested the diffviewer page.	6722494ccd7439a894f964f6b7e9f1db588e7e86	David Trowbridge

Files

	reviewboard/static/rb/js/reviews/models/diffViewerPageModel.ts
	reviewboard/static/rb/js/reviews/models/reviewablePageModel.ts
	reviewboard/static/rb/js/reviews/views/diffViewerPageView.ts

reviewboard/static/rb/js/reviews/models/diffViewerPageModel.ts

reviewboard/static/rb/js/reviews/models/reviewablePageModel.ts

reviewboard/static/rb/js/reviews/views/diffViewerPageView.ts