flake8
passed.
JSHint
passed.
Port DiffViewerPage and DiffViewerPageView to spina.
Review Request #12940 — Created April 5, 2023 and submitted
This change ports the diffviewer page model and view to spina. These
files have been moved into thereviewssubdirectory to correspond to
the bundle they're a part of.
- Ran js-tests.
- Tested the diffviewer page.
| Summary | ID |
|---|---|
| cbd21aaa36381889c43c6323def62bb5df33efa0 |
| Description | From | Last Updated |
|---|---|---|
|
Typo: "omdified" -> "modified" |
 chipx86
|
|
|
Do we want to document the incoming data to be parsed? I feel it's still useful, maybe to list what … |
chipx86
|
|
|
Second sentence must be in the description body. |
chipx86
|
|
|
This should have a type. |
chipx86
|
|
|
Summary should be on the next line. |
chipx86
|
|
|
Missing docs. |
chipx86
|
|
|
We should probably just accept ...args: any[] and pass that in super.initialize(). |
chipx86
|
|
|
Since there are multiple types involved, can we put the param and the return type on their own lines? |
chipx86
|
|
|
Probably worth making this an interface, so we can reference it elsewhere. |
chipx86
|
|
|
Should we accept/pass ...args: any[]? |
chipx86
|
|
|
I know we already had this, but we should probably do this last (and just return the result) so we … |
chipx86
|
|
|
Let's add an interface for this. We can then move the documentation into that. |
chipx86
|
|
|
Maybe here too? |
chipx86
|
|
|
Can we move to one type per line? |
chipx86
|
- Change Summary:
-
Removed a missed file in staticbundles.py
- Commits:
-
Summary ID 16c3eb701a4db9bf5c4dba18d2b41fa46f58877e 3a54662e7ce68c062ec29df60d2ad18c4083567e - Diff:
-
Revision 2 (+1084 -672)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
-
Do we want to document the incoming data to be parsed? I feel it's still useful, maybe to list what they'd map to.
-
-
-
-
Since there are multiple types involved, can we put the param and the return type on their own lines?
-
-
-
I know we already had this, but we should probably do this last (and just return the result) so we can clear up sub-views before this view's element goes away.
-
-
-
- Commits:
-
Summary ID 3a54662e7ce68c062ec29df60d2ad18c4083567e 6722494ccd7439a894f964f6b7e9f1db588e7e86 - Diff:
-
Revision 3 (+1186 -756)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Commits:
-
Summary ID 6722494ccd7439a894f964f6b7e9f1db588e7e86 eeb6af64de4c05d4ef2346d72caa9451c892fa5a - Diff:
-
Revision 4 (+1196 -756)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Change Summary:
-
Make a bunch of things private that can be private.
- Commits:
-
Summary ID eeb6af64de4c05d4ef2346d72caa9451c892fa5a cbd21aaa36381889c43c6323def62bb5df33efa0 - Diff:
-
Revision 5 (+1232 -792)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.