flake8
passed.
JSHint
passed.
Port DiffViewerPage and DiffViewerPageView to spina.
Review Request #12940 — Created April 5, 2023 and submitted
| Information | |
|---|---|
| david | |
| Review Board | |
| release-6.x | |
| Reviewers | |
| reviewboard | |
This change ports the diffviewer page model and view to spina. These
files have been moved into thereviewssubdirectory to correspond to
the bundle they're a part of.
- Ran js-tests.
- Tested the diffviewer page.
| Summary | |
|---|---|
| Description | From | Last Updated |
|---|---|---|
|
Typo: "omdified" -> "modified" |
 chipx86
|
|
|
Do we want to document the incoming data to be parsed? I feel it's still useful, maybe to list what … |
chipx86
|
|
|
Second sentence must be in the description body. |
chipx86
|
|
|
This should have a type. |
chipx86
|
|
|
Summary should be on the next line. |
chipx86
|
|
|
Missing docs. |
chipx86
|
|
|
We should probably just accept ...args: any[] and pass that in super.initialize(). |
chipx86
|
|
|
Since there are multiple types involved, can we put the param and the return type on their own lines? |
chipx86
|
|
|
Probably worth making this an interface, so we can reference it elsewhere. |
chipx86
|
|
|
Should we accept/pass ...args: any[]? |
chipx86
|
|
|
I know we already had this, but we should probably do this last (and just return the result) so we … |
chipx86
|
|
|
Let's add an interface for this. We can then move the documentation into that. |
chipx86
|
|
|
Maybe here too? |
chipx86
|
|
|
Can we move to one type per line? |
chipx86
|
Change Summary:
Removed a missed file in staticbundles.py
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+1084 -672) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
reviewboard/static/rb/js/reviews/models/diffViewerPageModel.ts (Diff revision 2) Typo: "omdified" -> "modified"
-
reviewboard/static/rb/js/reviews/models/diffViewerPageModel.ts (Diff revision 2) Do we want to document the incoming data to be parsed? I feel it's still useful, maybe to list what they'd map to.
-
reviewboard/static/rb/js/reviews/models/diffViewerPageModel.ts (Diff revision 2) This should have a type.
-
-
reviewboard/static/rb/js/reviews/models/diffViewerPageModel.ts (Diff revision 2) We should probably just accept
...args: any[]and pass that insuper.initialize(). -
reviewboard/static/rb/js/reviews/models/diffViewerPageModel.ts (Diff revision 2) Since there are multiple types involved, can we put the param and the return type on their own lines?
-
reviewboard/static/rb/js/reviews/models/diffViewerPageModel.ts (Diff revision 2) Probably worth making this an
interface, so we can reference it elsewhere. -
reviewboard/static/rb/js/reviews/views/diffViewerPageView.ts (Diff revision 2) Should we accept/pass
...args: any[]? -
reviewboard/static/rb/js/reviews/views/diffViewerPageView.ts (Diff revision 2) I know we already had this, but we should probably do this last (and just return the result) so we can clear up sub-views before this view's element goes away.
-
reviewboard/static/rb/js/reviews/views/diffViewerPageView.ts (Diff revision 2) Let's add an interface for this. We can then move the documentation into that.
-
-
reviewboard/static/rb/js/reviews/models/reviewablePageModel.ts (Diff revision 2) Can we move to one type per line?
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+1186 -756) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
reviewboard/static/rb/js/reviews/models/diffViewerPageModel.ts (Diff revisions 2 - 3) Second sentence must be in the description body.
-
reviewboard/static/rb/js/reviews/models/diffViewerPageModel.ts (Diff revisions 2 - 3) Summary should be on the next line.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+1196 -756) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Change Summary:
Make a bunch of things private that can be private.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+1232 -792) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.