flake8
passed.
JSHint
passed.
Port ReviewablePage and ReviewablePageView to spina.
Review Request #12938 — Created April 5, 2023 and submitted
| Information | |
|---|---|
| david | |
| Review Board | |
| release-6.x | |
| Reviewers | |
| reviewboard | |
This change ports the reviewable page model and view to spina. These
files have been moved into thereviewssubdirectory to correspond to
the bundle they're a part of.
- Ran js-tests.
- Verified that reviewable pages still functioned correctly.
| Summary | |
|---|---|
| Description | From | Last Updated |
|---|---|---|
|
This needs a type. |
 chipx86
|
|
|
Missing docs for options. Or should we just take ...args[]? |
chipx86
|
|
|
These are missing docs. |
chipx86
|
|
|
Missing docs. |
chipx86
|
|
|
Missing docs. |
chipx86
|
|
|
This can be return super.remove(); |
chipx86
|
|
|
This can be: const name = info.user.fullname || info.user.username; _`Review request #${reviewRequest.id}, by ${name}` It'll automatically turn it into an … |
chipx86
|
Change Summary:
- Parameterize
ReviewablePageViewso subclasses can change the type of the model and options. - Use absolute imports for tests files so they correctly pull in from the other bundles.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+694 -418) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
-
reviewboard/static/rb/js/reviews/models/reviewablePageModel.ts (Diff revision 2) Missing docs for
options. Or should we just take...args[]? -
reviewboard/static/rb/js/reviews/views/reviewablePageView.ts (Diff revision 2) These are missing docs.
-
-
-
reviewboard/static/rb/js/reviews/views/reviewablePageView.ts (Diff revision 2) This can be
return super.remove(); -
reviewboard/static/rb/js/reviews/views/reviewablePageView.ts (Diff revision 2) This can be:
const name = info.user.fullname || info.user.username; _`Review request #${reviewRequest.id}, by ${name}`It'll automatically turn it into an
interpolate(but it's best to keep the values simple, as above.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+738 -426) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.