Port ReviewablePage and ReviewablePageView to spina.

Review Request #12938 — Created April 5, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

This change ports the reviewable page model and view to spina. These
files have been moved into the reviews subdirectory to correspond to
the bundle they're a part of.

  • Ran js-tests.
  • Verified that reviewable pages still functioned correctly.
Summary ID
Port ReviewablePage and ReviewablePageView to spina.
This change ports the reviewable page model and view to spina. These files have been moved into the `reviews` subdirectory to correspond to the bundle they're a part of. Testing Done: - Ran js-tests. - Verified that reviewable pages still functioned correctly.
7d0530599bcea3248af0b99b7b42320b3c5badb2
Description From Last Updated

This needs a type.

chipx86chipx86

Missing docs for options. Or should we just take ...args[]?

chipx86chipx86

These are missing docs.

chipx86chipx86

Missing docs.

chipx86chipx86

Missing docs.

chipx86chipx86

This can be return super.remove();

chipx86chipx86

This can be: const name = info.user.fullname || info.user.username; _`Review request #${reviewRequest.id}, by ${name}` It'll automatically turn it into an …

chipx86chipx86
david
chipx86
  1. 
      
  2. Show all issues

    This needs a type.

  3. Show all issues

    Missing docs for options. Or should we just take ...args[]?

  4. reviewboard/static/rb/js/reviews/views/reviewablePageView.ts (Diff revision 2)
     
     
     
     
     
     
     
     
     
    Show all issues

    These are missing docs.

  5. Show all issues

    Missing docs.

  6. reviewboard/static/rb/js/reviews/views/reviewablePageView.ts (Diff revision 2)
     
     
     
     
     
     
     
     
     
    Show all issues

    Missing docs.

  7. Show all issues

    This can be return super.remove();

  8. Show all issues

    This can be:

    const name = info.user.fullname || info.user.username;
    
    _`Review request #${reviewRequest.id}, by ${name}`
    

    It'll automatically turn it into an interpolate (but it's best to keep the values simple, as above.

  9. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (4d474e8)
Loading...