Summary

Port ReviewablePage and ReviewablePageView to spina.

Review Request #12938 — Created April 5, 2023 and submitted April 20, 2023, 8:03 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change ports the reviewable page model and view to spina. These
files have been moved into the reviews subdirectory to correspond to
the bundle they're a part of.

Testing Done


Ran js-tests.
Verified that reviewable pages still functioned correctly.

Commits

Summary	ID
Port ReviewablePage and ReviewablePageView to spina. This change ports the reviewable page model and view to spina. These files have been moved into the `reviews` subdirectory to correspond to the bundle they're a part of. Testing Done: - Ran js-tests. - Verified that reviewable pages still functioned correctly.	7d0530599bcea3248af0b99b7b42320b3c5badb2

Issues

Description	From	Last Updated
This needs a type.	chipx86	April 18, 2023, 10:12 a.m.
Missing docs for options. Or should we just take ...args[]?	chipx86	April 18, 2023, 10:13 a.m.
These are missing docs.	chipx86	April 18, 2023, 10:13 a.m.
Missing docs.	chipx86	April 18, 2023, 10:14 a.m.
Missing docs.	chipx86	April 18, 2023, 10:15 a.m.
This can be return super.remove();	chipx86	April 18, 2023, 10:15 a.m.
This can be: const name = info.user.fullname \|\| info.user.username; _`Review request #${reviewRequest.id}, by ${name}` It'll automatically turn it into an …	chipx86	April 18, 2023, 10:16 a.m.

flake8 passed.

JSHint passed.

Change Summary:


Parameterize ReviewablePageView so subclasses can change the type of the model and options.
Use absolute imports for tests files so they correctly pull in from the other bundles.

Commits:

	Summary	ID
	Port ReviewablePage and ReviewablePageView to spina. This change ports the reviewable page model and view to spina. These files have been moved into the `reviews` subdirectory to correspond to the bundle they're a part of. Testing Done: - Ran js-tests. - Verified that reviewable pages still functioned correctly.	2d2ea7d28538acafdacc9308b0c242423d486893
	Port ReviewablePage and ReviewablePageView to spina. This change ports the reviewable page model and view to spina. These files have been moved into the `reviews` subdirectory to correspond to the bundle they're a part of. Testing Done: - Ran js-tests. - Verified that reviewable pages still functioned correctly.	f033f36814f01af5a986866c2aaca12afb8f6790

Diff:

Revision 2 (+694 -418)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js
	reviewboard/static/rb/js/reviews/index.ts
	reviewboard/static/rb/js/pages/models/reviewablePageModel.es6.js
	reviewboard/static/rb/js/reviews/models/tests/index.ts
	reviewboard/static/rb/js/pages/models/tests/reviewablePageModelTests.es6.js
	reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
	reviewboard/static/rb/js/reviews/views/tests/index.ts
	2 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/reviews/models/reviewablePageModel.ts (Diff revision 2)
The issue has been resolved. Show all issues
```
This needs a type.
```

reviewboard/static/rb/js/reviews/models/reviewablePageModel.ts (Diff revision 2)

The issue has been resolved. Show all issues

Missing docs for options. Or should we just take ...args[]?

reviewboard/static/rb/js/reviews/views/reviewablePageView.ts (Diff revision 2)

The issue has been resolved. Show all issues

These are missing docs.

reviewboard/static/rb/js/reviews/views/reviewablePageView.ts (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing docs.
```

reviewboard/static/rb/js/reviews/views/reviewablePageView.ts (Diff revision 2)

The issue has been resolved. Show all issues

Missing docs.

reviewboard/static/rb/js/reviews/views/reviewablePageView.ts (Diff revision 2)
The issue has been resolved. Show all issues
```
This can be return super.remove();
```

reviewboard/static/rb/js/reviews/views/reviewablePageView.ts (Diff revision 2)

The issue has been resolved. Show all issues

This can be:

const name = info.user.fullname || info.user.username;

_`Review request #${reviewRequest.id}, by ${name}`


It'll automatically turn it into an interpolate (but it's best to keep the values simple, as above.

Commits:

	Summary	ID
	Port ReviewablePage and ReviewablePageView to spina. This change ports the reviewable page model and view to spina. These files have been moved into the `reviews` subdirectory to correspond to the bundle they're a part of. Testing Done: - Ran js-tests. - Verified that reviewable pages still functioned correctly.	f033f36814f01af5a986866c2aaca12afb8f6790
	Port ReviewablePage and ReviewablePageView to spina. This change ports the reviewable page model and view to spina. These files have been moved into the `reviews` subdirectory to correspond to the bundle they're a part of. Testing Done: - Ran js-tests. - Verified that reviewable pages still functioned correctly.	7d0530599bcea3248af0b99b7b42320b3c5badb2

Diff:

Revision 3 (+738 -426)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js
	reviewboard/static/rb/js/reviews/index.ts
	reviewboard/static/rb/js/pages/models/reviewablePageModel.es6.js
	reviewboard/static/rb/js/reviews/models/tests/index.ts
	reviewboard/static/rb/js/pages/models/tests/reviewablePageModelTests.es6.js
	reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
	reviewboard/static/rb/js/reviews/views/tests/index.ts
	2 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-6.x (4d474e8)