Port PageView to spina.
Review Request #12937 — Created April 5, 2023 and submitted — Latest diff uploaded
This change ports the base PageView class to spina and TypeScript. As
part of this, the code has been moved into thecommon
subdirectory to
match the bundle that it's a part of.The one change that was required outside of this class was to update the
DiffViewerPageModel
to usepreinitialize
instead ofconstructor
.
The use of the reserved nameconstructor
has bitten us in the past,
and wasn't working anymore now that the base class was an ES6 class.
- Ran js-tests.
- Verified that page views still rendered correctly.