Port PageView to spina.

 






 

 


  Review Request #12937
  —
  Created April 5, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-6.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change ports the base PageView class to spina and TypeScript. As

part of this, the code has been moved into the common subdirectory to

match the bundle that it's a part of.


The one change that was required outside of this class was to update the

DiffViewerPageModel to use preinitialize instead of constructor.

The use of the reserved name constructor has bitten us in the past,

and wasn't working anymore now that the base class was an ES6 class.

 








  


 
 

  
    

  • Ran js-tests.
    • 

  • Verified that page views still rendered correctly.
    • 


 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Port PageView to spina.
     
This change ports the base PageView class to spina and TypeScript. As
part of this, the code has been moved into the `common` subdirectory to
match the bundle that it's a part of.

The one change that was required outside of this class was to update the
`DiffViewerPageModel` to use `preinitialize` instead of `constructor`.
The use of the reserved name `constructor` has bitten us in the past,
and wasn't working anymore now that the base class was an ES6 class.

Testing Done:
- Ran js-tests.
- Verified that page views still rendered correctly.

    

   
  		
  4b61d130832830223195d265e9b0e02c161cbd6d
  David Trowbridge
 


 
  
 
 
  
   
    

     Port PageView to spina.
     
This change ports the base PageView class to spina and TypeScript. As
part of this, the code has been moved into the `common` subdirectory to
match the bundle that it's a part of.

The one change that was required outside of this class was to update the
`DiffViewerPageModel` to use `preinitialize` instead of `constructor`.
The use of the reserved name `constructor` has bitten us in the past,
and wasn't working anymore now that the base class was an ES6 class.

Testing Done:
- Ran js-tests.
- Verified that page views still rendered correctly.

    

   
  		
  bf63aeed7cb7febfec71b026b87c46c6acc793c9
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/common/views/pageView.ts
     
    

   
  

 










     

    

   

  

  

   
   Loading...