Summary

Port DiffComplexityIconView and DiffFileIndexView to spina.

Review Request #12936 — Created April 4, 2023 and submitted April 20, 2023, 8:03 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change ports two of the classes used to implement the file index
over to TypeScript and spina. They've been moved into the reviews
subdirectory in order to correspond with the bundle that they're a part
of.

Testing Done


Ran js-tests.
Used these in conjunction with other changes to the file index.

Commits

Summary	ID
Port DiffComplexityIconView and DiffFileIndexView to spina. This change ports two of the classes used to implement the file index over to TypeScript and spina. They've been moved into the `reviews` subdirectory in order to correspond with the bundle that they're a part of. Testing Done: - Ran js-tests. - Used these in conjunction with other changes to the file index.	5cb8cd7743d97f290def485e3ab4d930c4cebfdd

Issues

Description	From	Last Updated
Can we add docs for these?	chipx86	April 18, 2023, 9:38 a.m.
Docs?	chipx86	April 18, 2023, 9:39 a.m.

flake8 passed.

JSHint passed.

Change Summary:

Alphabetize exports from index

Commits:

	Summary	ID
	Port DiffComplexityIconView and DiffFileIndexView to spina. This change ports two of the classes used to implement the file index over to TypeScript and spina. They've been moved into the `reviews` subdirectory in order to correspond with the bundle that they're a part of. Testing Done: - Ran js-tests. - Used these in conjunction with other changes to the file index.	4c5284d454e26bba5097f9a56453f6f4fa61e77c
	Port DiffComplexityIconView and DiffFileIndexView to spina. This change ports two of the classes used to implement the file index over to TypeScript and spina. They've been moved into the `reviews` subdirectory in order to correspond with the bundle that they're a part of. Testing Done: - Ran js-tests. - Used these in conjunction with other changes to the file index.	3b8863a3cb09c7f147e0cd59df3700720a01020b

Diff:

Revision 2 (+366 -242)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/reviews/index.ts
	reviewboard/static/rb/js/diffviewer/views/diffComplexityIconView.es6.js
	reviewboard/static/rb/js/diffviewer/views/diffFileIndexView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/reviews/views/diffComplexityIconView.ts (Diff revision 2)
The issue has been resolved. Show all issues
```
Can we add docs for these?
```
reviewboard/static/rb/js/reviews/views/diffComplexityIconView.ts (Diff revision 2)
The issue has been resolved. Show all issues
```
Docs?
```

Commits:

	Summary	ID
	Port DiffComplexityIconView and DiffFileIndexView to spina. This change ports two of the classes used to implement the file index over to TypeScript and spina. They've been moved into the `reviews` subdirectory in order to correspond with the bundle that they're a part of. Testing Done: - Ran js-tests. - Used these in conjunction with other changes to the file index.	3b8863a3cb09c7f147e0cd59df3700720a01020b
	Port DiffComplexityIconView and DiffFileIndexView to spina. This change ports two of the classes used to implement the file index over to TypeScript and spina. They've been moved into the `reviews` subdirectory in order to correspond with the bundle that they're a part of. Testing Done: - Ran js-tests. - Used these in conjunction with other changes to the file index.	5cb8cd7743d97f290def485e3ab4d930c4cebfdd

Diff:

Revision 3 (+392 -242)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/reviews/index.ts
	reviewboard/static/rb/js/diffviewer/views/diffComplexityIconView.es6.js
	reviewboard/static/rb/js/diffviewer/views/diffFileIndexView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (02859df)