Make it posible to import jasmine.

Review Request #12935 — Created April 4, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

Test files using jasmine were extremely ugly with lots of errors,
because all of the jasmine methods were just loaded as globals. This
change adds the relevant rollup configuration so that we can import
those methods and properly have them get mapped to the items on
window.

This also fixes the package dependency to be jasmine-core, which is
the correct name on npm. The jasmine npm package is a CLI tool for
running tests, rather than the library.

Used this in conjunction with changes that did
import { ... } from 'jasmine' and saw that all unit tests ran
correctly.

Summary ID
Make it posible to import jasmine.
Test files using jasmine were extremely ugly with lots of errors, because all of the jasmine methods were just loaded as globals. This change adds the relevant rollup configuration so that we can import those methods and properly have them get mapped to the items on `window`. This also fixes the package dependency to be `jasmine-core`, which is the correct name on npm. The `jasmine` npm package is a CLI tool for running tests, rather than the library. Testing Done: Used this in conjunction with changes that did `import { ... } from 'jasmine'` and saw that all unit tests ran correctly.
31828a242f171c00873d47e99d3165da15c186e8
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (12a8481)
Loading...