flake8
passed.
JSHint
passed.
Review Request #12935 — Created April 4, 2023 and submitted
Test files using jasmine were extremely ugly with lots of errors,
because all of the jasmine methods were just loaded as globals. This
change adds the relevant rollup configuration so that we can import
those methods and properly have them get mapped to the items on
window
.This also fixes the package dependency to be
jasmine-core
, which is
the correct name on npm. Thejasmine
npm package is a CLI tool for
running tests, rather than the library.
Used this in conjunction with changes that did
import { ... } from 'jasmine'
and saw that all unit tests ran
correctly.
Summary | ID |
---|---|
31828a242f171c00873d47e99d3165da15c186e8 |