Fix js-tests for the ReviewDialogView navigation fix.

 






 

 


  Review Request #12932
  —
  Created April 4, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-6.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
The fix for ReviewDialogView to reload the page was causing the browser

to navigate away from the page when running js-tests. This change adds a

spy to prevent RB.navigateTo from being called.

 








  


 
 

  
Ran js-tests successfully.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Fix js-tests for the ReviewDialogView navigation fix.
     
The fix for ReviewDialogView to reload the page was causing the browser
to navigate away from the page when running js-tests. This change adds a
spy to prevent RB.navigateTo from being called.

Testing Done:
Ran js-tests successfully.

    

   
  		
  d339c3b1200d6ab5eb7701ee06d7284f3bfec388
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/views/tests/reviewDialogViewTests.es6.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...