flake8
passed.
JSHint
passed.
Add back in the interdiff link on draft banners.
Review Request #12930 — Created April 1, 2023 and submitted
| Information | |
|---|---|
| david | |
| Review Board | |
| release-6.x | |
| Reviewers | |
| reviewboard | |
The unified draft banner implementation was missing the link to the
interdiff when present. This change adds in it.
Created a review request draft that added a new diff. Saw the interdiff
link was visible and worked correctly. Checked that it was properly
hidden for drafts that did not add a new diff or when the selected draft
mode did not include the review request changes.
| Summary | |
|---|---|
| Description | From | Last Updated |
|---|---|---|
|
A TODO for later (or now if you feel like it), but none of these detail the structure of the … |
 chipx86
|
|
|
Small nit: If we use dedent, the resulting minified code won't have to have all this whitespace. |
chipx86
|
|
|
I'm pretty sure any gettext calls inside a template literal won't be scanned when building up a translation strings file. |
chipx86
|
-
-
reviewboard/static/rb/css/ui/banners.less (Diff revision 1) A TODO for later (or now if you feel like it), but none of these detail the structure of the component. I'd like to make sure we stick with that, since it can really help in seeing how the parts fit together.
We also need to go through and make sure all this is fully accessible before release.
-
reviewboard/static/rb/js/reviews/views/unifiedBannerView.ts (Diff revision 1) Small nit: If we use
dedent, the resulting minified code won't have to have all this whitespace. -
reviewboard/static/rb/js/reviews/views/unifiedBannerView.ts (Diff revision 1) I'm pretty sure any
gettextcalls inside a template literal won't be scanned when building up a translation strings file.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+70) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.