Add back in the interdiff link on draft banners.

Review Request #12930 — Created April 1, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

The unified draft banner implementation was missing the link to the
interdiff when present. This change adds in it.

Created a review request draft that added a new diff. Saw the interdiff
link was visible and worked correctly. Checked that it was properly
hidden for drafts that did not add a new diff or when the selected draft
mode did not include the review request changes.

Summary ID
Add back in the interdiff link on draft banners.
The unified draft banner implementation was missing the link to the interdiff when present. This change adds in it. Testing Done: Created a review request draft that added a new diff. Saw the interdiff link was visible and worked correctly. Checked that it was properly hidden for drafts that did not add a new diff or when the selected draft mode did not include the review request changes.
5218c8064db70135e439e34e2f389bc7371ba713
Description From Last Updated

A TODO for later (or now if you feel like it), but none of these detail the structure of the …

chipx86chipx86

Small nit: If we use dedent, the resulting minified code won't have to have all this whitespace.

chipx86chipx86

I'm pretty sure any gettext calls inside a template literal won't be scanned when building up a translation strings file.

chipx86chipx86
chipx86
  1. 
      
  2. A TODO for later (or now if you feel like it), but none of these detail the structure of the component. I'd like to make sure we stick with that, since it can really help in seeing how the parts fit together.

    We also need to go through and make sure all this is fully accessible before release.

    1. Except for this new one, all of the ones that don't have "Structure" are simple elements which are documented fully as part of container elements. I'll add it for this one.

  3. reviewboard/static/rb/js/reviews/views/unifiedBannerView.ts (Diff revision 1)
     
     
     
     
     
     
     

    Small nit: If we use dedent, the resulting minified code won't have to have all this whitespace.

  4. I'm pretty sure any gettext calls inside a template literal won't be scanned when building up a translation strings file.

    1. Just tested it and they get extracted correctly.

  5. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (ce8b242)
Loading...