Customizablility of modal boxes.

Review Request #1293 - Created Dec. 4, 2009 and submitted

Chris Trimble
Djblets
reviewboard
This is a small change to djblets that allows us to easily change the class of a modal box.  This allows reuse of existing tech for reviewboard rather than integrating thickbox into our help system.  See screenshot below for example (implementation of exact dialog will be added to request 1281 http://reviews.reviewboard.org/r/1281/ )
Local against mainline djblets + change and mainline reviewboard.
Christian Hammond
  1. Looks good. One small thing.
  2. djblets/media/js/jquery.gravy.js (Diff revision 1)
     
     
     
     
    Can you insert these in the list such that the entire set of options are alphabetical?
  3. 
      
Chris Trimble
Chris Trimble
Review request changed

Change Summary:

with working code this time!  (commas)

Diff:

Revision 3 (+6 -3)

Show changes

Christian Hammond
  1. Thanks Chris. Looks good.
    
    Should I credit Hussain Bohra on all these changes?
  2. 
      
Loading...