Summary

Add unit tests for base class support, and fix some issues.

Review Request #12916 — Created March 24, 2023 and submitted March 24, 2023, 5:39 p.m.

Information

Owner

chipx86

Repository

Spina

Branch

master

Bugs

Depends On

Reviewers

Groups

beanbag-misc

People

Description

This change adds a new test suite covering spinaBaseClassExtends()

(and a lot of common code shared with @spina).
In the process, some typing and runtime issues were found and fixed:


Mixins can now mix in static members.


Mixins are now applied before processing attributes, allowing for

  static members to be mixed in and processed.


An attribute was unnecessarily set twice when copying static members

  to the prototype.


extend() is now part of the SpinaClass interface.


Some functions now reference PartialSpinaClass rather than

SpinaClass, when working with a class that hasn't yet been fully

  processed.

Testing Done

Unit tests pass.

Commits

Summary	ID
Add unit tests for base class support, and fix some issues. This change adds a new test suite covering `spinaBaseClassExtends()` (and a lot of common code shared with `@spina`). In the process, some typing and runtime issues were found and fixed: * Mixins can now mix in static members. * Mixins are now applied before processing attributes, allowing for static members to be mixed in and processed. * An attribute was unnecessarily set twice when copying static members to the prototype. * `extend()` is now part of the `SpinaClass` interface. * Some functions now reference `PartialSpinaClass` rather than `SpinaClass`, when working with a class that hasn't yet been fully processed.	94d5f3be16d39b57b07d570a54ecefa281110747

Summary

Add unit tests for base class support, and fix some issues.

This change adds a new test suite covering `spinaBaseClassExtends()` (and a lot of common code shared with `@spina`). In the process, some typing and runtime issues were found and fixed: * Mixins can now mix in static members. * Mixins are now applied before processing attributes, allowing for static members to be mixed in and processed. * An attribute was unnecessarily set twice when copying static members to the prototype. * `extend()` is now part of the `SpinaClass` interface. * Some functions now reference `PartialSpinaClass` rather than `SpinaClass`, when working with a class that hasn't yet been fully processed.

94d5f3be16d39b57b07d570a54ecefa281110747

flake8 passed.

JSHint passed.

Change Summary:

Added the missing tests file.

Commits:

	Summary	ID
	Add unit tests for base class support, and fix some issues. This change adds a new test suite covering `spinaBaseClassExtends()` (and a lot of common code shared with `@spina`). In the process, some typing and runtime issues were found and fixed: * Mixins can now mix in static members. * Mixins are now applied before processing attributes, allowing for static members to be mixed in and processed. * An attribute was unnecessarily set twice when copying static members to the prototype. * `extend()` is now part of the `SpinaClass` interface. * Some functions now reference `PartialSpinaClass` rather than `SpinaClass`, when working with a class that hasn't yet been fully processed.	9157bf794cc4c6d43c215dae46428acf8922b8d8
	Add unit tests for base class support, and fix some issues. This change adds a new test suite covering `spinaBaseClassExtends()` (and a lot of common code shared with `@spina`). In the process, some typing and runtime issues were found and fixed: * Mixins can now mix in static members. * Mixins are now applied before processing attributes, allowing for static members to be mixed in and processed. * An attribute was unnecessarily set twice when copying static members to the prototype. * `extend()` is now part of the `SpinaClass` interface. * Some functions now reference `PartialSpinaClass` rather than `SpinaClass`, when working with a class that hasn't yet been fully processed.	94d5f3be16d39b57b07d570a54ecefa281110747

Diff:

Revision 2 (+650 -30)

Show changes

	src/objects.ts
	src/tests/spinaBaseClassExtendsTests.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (0ab7410)