Summary:

Remove deprecated code from Djblets.

Review Request #12897 — Created March 17, 2023 and updated March 24, 2023, 9:55 a.m.

Information
Owner:	david
Repository:	Djblets
Branch:	release-4.x
Bugs:
Depends On:
Reviewers
Groups:	djblets
People:

Description

This change removes all deprecated code marked for removal in Djblets
4.0. The only complicated part of this is the ListEditWidget, which had
a "legacy" mode in which the widget handled separators and value
splitting. This wasn't used anywhere except unit tests.

Testing Done

Ran unit tests.

Commits

Summary
	Remove deprecated code from Djblets.

Screenshots

Issues

Description	From	Last Updated
Instead of "with a string of separated values" can you update this to say "with a list of values" here.	maubin	March 20, 2023, 9:29 p.m.
Given the deprecation info, if we make these keyword-only arguments and use the decorator, we can make token_info and token_generator_id …	chipx86	March 24, 2023, 8:18 a.m.

flake8 passed.

JSHint passed.

djblets/forms/tests/test_list_edit_widget.py (Diff revision 1)

Show all issues

Instead of "with a string of separated values" can you update this to say "with a list of values" here.

Commits:

	Summary
-		Remove deprecated code from Djblets.
+		Remove deprecated code from Djblets.

Diff:

Revision 2 (+36 -1008)

Show changes

	djblets/deprecation.py
	djblets/datagrid/grids.py
	djblets/datagrid/tests.py
	djblets/forms/widgets.py
	djblets/forms/tests/test_list_edit_widget.py
	djblets/integrations/urls.py
	djblets/webapi/managers.py
	djblets/webapi/responses.py
	2 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

djblets/webapi/managers.py (Diff revision 2)

Show all issues

Given the deprecation info, if we make these keyword-only arguments and use the decorator, we can make token_info and token_generator_id mandatory by removing the None default.

Commits:

	Summary
-		Remove deprecated code from Djblets.
+		Remove deprecated code from Djblets.

Diff:

Revision 3 (+46 -1024)

Show changes

	djblets/deprecation.py
	djblets/datagrid/grids.py
	djblets/datagrid/tests.py
	djblets/forms/widgets.py
	djblets/forms/tests/test_list_edit_widget.py
	djblets/integrations/urls.py
	djblets/webapi/managers.py
	djblets/webapi/responses.py
	2 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```