flake8
passed.
JSHint
passed.
Remove deprecated code from Djblets.
Review Request #12897 — Created March 17, 2023 and submitted
| Information | |
|---|---|
| david | |
| Djblets | |
| release-4.x | |
| Reviewers | |
| djblets | |
This change removes all deprecated code marked for removal in Djblets
4.0. The only complicated part of this is the ListEditWidget, which had
a "legacy" mode in which the widget handled separators and value
splitting. This wasn't used anywhere except unit tests.
Ran unit tests.
-
-
djblets/forms/tests/test_list_edit_widget.py (Diff revision 1) Instead of "with a string of separated values" can you update this to say "with a list of values" here.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+36 -1008) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
djblets/webapi/managers.py (Diff revision 2) Given the deprecation info, if we make these keyword-only arguments and use the decorator, we can make
token_infoandtoken_generator_idmandatory by removing theNonedefault.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+46 -1024) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.