Fix creating CC/VV diffs that have moved files.

 






 

 


  Review Request #12893
  —
  Created March 15, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  RBTools
 









 
 

  release-4.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
Some code movement in the ClearCase/VersionVault client ended up breaking

the moved file case, where we tried to access a variable before defining it.

This wasn't immediately caught because my local test cases involved activities

that created a new file and then moved it, all in the same activity (which works

correctly).

 








  


 
 

  
Created an activity that moved an existing file. Saw the correct diff instead of

an RBTools crash.

 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Fix creating CC/VV diffs that have moved files.
     
Some code movement in the ClearCase/VersionVault client ended up breaking
the moved file case, where we tried to access a variable before defining it.
This wasn't immediately caught because my local test cases involved activities
that created a new file and then moved it, all in the same activity (which works
correctly).

Testing Done:
Created an activity that moved an existing file. Saw the correct diff instead of
an RBTools crash.

    

   
  		
  b8e38485e01e7f7941ee096bc1cbaadc92939b9d
  David Trowbridge
 


 
  
 
 
  
   
    

     Fix creating CC/VV diffs that have moved files.
     
Some code movement in the ClearCase/VersionVault client ended up breaking
the moved file case, where we tried to access a variable before defining it.
This wasn't immediately caught because my local test cases involved activities
that created a new file and then moved it, all in the same activity (which works
correctly).

Testing Done:
Created an activity that moved an existing file. Saw the correct diff instead of
an RBTools crash.

    

   
  		
  c2a33d0e9eabc564088e5c2de598192f42f7f066
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      rbtools/clients/clearcase.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...