Summary

Fix creating CC/VV diffs that have moved files.

Review Request #12893 — Created March 15, 2023 and submitted March 15, 2023, 3:03 p.m.

Information

Owner

david

Repository

RBTools

Branch

release-4.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Some code movement in the ClearCase/VersionVault client ended up breaking
the moved file case, where we tried to access a variable before defining it.
This wasn't immediately caught because my local test cases involved activities
that created a new file and then moved it, all in the same activity (which works
correctly).

Testing Done

Created an activity that moved an existing file. Saw the correct diff instead of
an RBTools crash.

Commits

Summary	ID
Fix creating CC/VV diffs that have moved files. Some code movement in the ClearCase/VersionVault client ended up breaking the moved file case, where we tried to access a variable before defining it. This wasn't immediately caught because my local test cases involved activities that created a new file and then moved it, all in the same activity (which works correctly). Testing Done: Created an activity that moved an existing file. Saw the correct diff instead of an RBTools crash.	c2a33d0e9eabc564088e5c2de598192f42f7f066

Summary

Fix creating CC/VV diffs that have moved files.

Some code movement in the ClearCase/VersionVault client ended up breaking the moved file case, where we tried to access a variable before defining it. This wasn't immediately caught because my local test cases involved activities that created a new file and then moved it, all in the same activity (which works correctly). Testing Done: Created an activity that moved an existing file. Saw the correct diff instead of an RBTools crash.

c2a33d0e9eabc564088e5c2de598192f42f7f066

Issues

Description	From	Last Updated
line too long (84 > 79 characters) Column: 80 Error code: E501	reviewbot	March 15, 2023, 12:24 p.m.

flake8 failed.

JSHint passed.

flake8

rbtools/clients/clearcase.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (84 > 79 characters)

Column: 80
Error code: E501
```

Commits:

	Summary	ID
	Fix creating CC/VV diffs that have moved files. Some code movement in the ClearCase/VersionVault client ended up breaking the moved file case, where we tried to access a variable before defining it. This wasn't immediately caught because my local test cases involved activities that created a new file and then moved it, all in the same activity (which works correctly). Testing Done: Created an activity that moved an existing file. Saw the correct diff instead of an RBTools crash.	b8e38485e01e7f7941ee096bc1cbaadc92939b9d
	Fix creating CC/VV diffs that have moved files. Some code movement in the ClearCase/VersionVault client ended up breaking the moved file case, where we tried to access a variable before defining it. This wasn't immediately caught because my local test cases involved activities that created a new file and then moved it, all in the same activity (which works correctly). Testing Done: Created an activity that moved an existing file. Saw the correct diff instead of an RBTools crash.	c2a33d0e9eabc564088e5c2de598192f42f7f066

Diff:

Revision 2 (+10 -10)

Show changes

rbtools/clients/clearcase.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (b35001a)