Summary

Fix a regression disabling syntax highlighting in the API.

Review Request #12887 — Created March 14, 2023 and submitted March 24, 2023, 6:54 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

We just recently moved to a new internal configuration model for

controlling the rendering pipeline, but one call location (the FileDiff

API) was still using the old method. That'd be fine, except the old

method wasn't properly converting a request to disable syntax

highlighting.
This led to requests for diff data to return HTML versions of lines

instead of plain text.
The settings migration code now allows for disabling settings, and the

API has been updated for the new settings code.
Unit tests check to ensure that we're properly getting plain-text back

from it, unless requested otherwise.

Testing Done

Verified that the API returned plain text data for any diffs I queried.

A customer verified this fixed a regression they noticed.

Unit tests passed.

Commits

Summary	ID
Fix a regression disabling syntax highlighting in the API. We just recently moved to a new internal configuration model for controlling the rendering pipeline, but one call location (the FileDiff API) was still using the old method. That'd be fine, except the old method wasn't properly converting a request to disable syntax highlighting. This led to requests for diff data to return HTML versions of lines instead of plain text. The settings migration code now allows for disabling settings, and the API has been updated for the new settings code. Unit tests check to ensure that we're properly getting plain-text back from it, unless requested otherwise.	ea70784ebb8b0726b54fae3cb5188184fe17d18c

Summary

Fix a regression disabling syntax highlighting in the API.

We just recently moved to a new internal configuration model for controlling the rendering pipeline, but one call location (the FileDiff API) was still using the old method. That'd be fine, except the old method wasn't properly converting a request to disable syntax highlighting. This led to requests for diff data to return HTML versions of lines instead of plain text. The settings migration code now allows for disabling settings, and the API has been updated for the new settings code. Unit tests check to ensure that we're properly getting plain-text back from it, unless requested otherwise.

ea70784ebb8b0726b54fae3cb5188184fe17d18c

Issues

Description	From	Last Updated
'reviewboard.webapi.tests.mimetypes.diff_data_mimetype' imported but unused Column: 1 Error code: F401	reviewbot	March 14, 2023, 4:50 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/tests/test_filediff.py (Diff revision 1)

Show all issues

'reviewboard.webapi.tests.mimetypes.diff_data_mimetype' imported but unused

Column: 1
Error code: F401

Change Summary:

Fixed an unused import for the new mimetype constant (but keeping the constant around to complete the test collection).

Commits:

	Summary	ID
	Fix a regression disabling syntax highlighting in the API. We just recently moved to a new internal configuration model for controlling the rendering pipeline, but one call location (the FileDiff API) was still using the old method. That'd be fine, except the old method wasn't properly converting a request to disable syntax highlighting. This led to requests for diff data to return HTML versions of lines instead of plain text. The settings migration code now allows for disabling settings, and the API has been updated for the new settings code. Unit tests check to ensure that we're properly getting plain-text back from it, unless requested otherwise.	63b89da0438bbd87cee8af79da2f38bb040eeeac
	Fix a regression disabling syntax highlighting in the API. We just recently moved to a new internal configuration model for controlling the rendering pipeline, but one call location (the FileDiff API) was still using the old method. That'd be fine, except the old method wasn't properly converting a request to disable syntax highlighting. This led to requests for diff data to return HTML versions of lines instead of plain text. The settings migration code now allows for disabling settings, and the API has been updated for the new settings code. Unit tests check to ensure that we're properly getting plain-text back from it, unless requested otherwise.	ea70784ebb8b0726b54fae3cb5188184fe17d18c

Diff:

Revision 2 (+318 -6)

Show changes

	reviewboard/diffviewer/diffutils.py
	reviewboard/webapi/resources/filediff.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_filediff.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (cfa25ea)