• 
      

    Make wording consistent for review request close terminology.

    Review Request #12879 — Created March 10, 2023 and submitted

    Information

    Review Board
    release-6.x

    Reviewers

    As part of the actions rework, I changed "Close -> Submitted" to
    "Close -> Completed". The word submitted is pretty unique to Perforce,
    and has been a source of confusion for users over the years, especially
    since in some contexts we used the word "submitted" to mean "put up for
    review".

    This change fixes up other uses of the "Submitted" term, including in
    the dashboard and the manual.

    We still use "submitted" on the backend, including in webhook
    notifications. This won't be changing because it's API.

    • Used the dashboard bulk mode and saw the correct wording.
    • Built the manual.
    Summary ID
    Make wording consistent for review request close terminology.
    As part of the actions rework, I changed "Close -> Submitted" to "Close -> Completed". The word submitted is pretty unique to Perforce, and has been a source of confusion for users over the years, especially since in some contexts we used the word "submitted" to mean "put up for review". This change fixes up other uses of the "Submitted" term, including in the dashboard and the manual. We still use "submitted" on the backend, including in webhook notifications. This won't be changing because it's API. Testing Done: - Used the dashboard bulk mode and saw the correct wording. - Built the manual.
    03a39a45f93fe69622b91c9d61bcd83745e5629c
    chipx86
    1. Excellent. A long-lasting pet peeve and a regret of mine from those initial days.

    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-6.x (307658b)