Fix issues with rendering the mode selector in the unified banner.

 






 

 


  Review Request #12875
  —
  Created March 8, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-6.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
On review feedback, I had changed the mode selector rendering to use

Spina's renderInto() method. This was not passing the correct element

to render into, but I didn't notice, because renderInto() had a bug

that prevented the menu from rendering at all.


This change also adds an extra call to #update() when we render, just

to ensure that it will always have the correct data.

 








  


 
 

  
Used the banner and once again saw the mode selector menu.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Fix issues with rendering the mode selector in the unified banner.
     
On review feedback, I had changed the mode selector rendering to use
Spina's `renderInto()` method. This was not passing the correct element
to render into, but I didn't notice, because `renderInto()` had a bug
that prevented the menu from rendering at all.

This change also adds an extra call to `#update()` when we render, just
to ensure that it will always have the correct data.

Testing Done:
Used the banner and once again saw the mode selector menu.

    

   
  		
  e112e7dc8bfdd979ce551da4dc8d8e2d68304d97
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/unifiedBannerView.ts
     
    

   
  

 










     

    

   

  

  

   
   Loading...