flake8
passed.
JSHint
passed.
Review Request #12875 — Created March 8, 2023 and submitted
Information | |
---|---|
david | |
Review Board | |
release-6.x | |
Reviewers | |
reviewboard | |
On review feedback, I had changed the mode selector rendering to use
Spina'srenderInto()
method. This was not passing the correct element
to render into, but I didn't notice, becauserenderInto()
had a bug
that prevented the menu from rendering at all.This change also adds an extra call to
#update()
when we render, just
to ensure that it will always have the correct data.
Used the banner and once again saw the mode selector menu.
Summary | |
---|---|