Fix issues with rendering the mode selector in the unified banner.

Review Request #12875 — Created March 8, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

On review feedback, I had changed the mode selector rendering to use
Spina's renderInto() method. This was not passing the correct element
to render into, but I didn't notice, because renderInto() had a bug
that prevented the menu from rendering at all.

This change also adds an extra call to #update() when we render, just
to ensure that it will always have the correct data.

Used the banner and once again saw the mode selector menu.

Summary ID
Fix issues with rendering the mode selector in the unified banner.
On review feedback, I had changed the mode selector rendering to use Spina's `renderInto()` method. This was not passing the correct element to render into, but I didn't notice, because `renderInto()` had a bug that prevented the menu from rendering at all. This change also adds an extra call to `#update()` when we render, just to ensure that it will always have the correct data. Testing Done: Used the banner and once again saw the mode selector menu.
e112e7dc8bfdd979ce551da4dc8d8e2d68304d97
maubin
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-6.x (59982f7)