Fix BaseView.renderInto() to actually call render().

 






 

 


  Review Request #12874
  —
  Created March 8, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Spina
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  beanbag-misc
 









 
 

  
 






 








 





  


 
 

  
The renderInto() helper method handled the DOM manipulation with

aplomb, but in a plot twist, neglected to ever call render(). This was

a simple oversight.

 








  


 
 

  
Used renderInto() and actually saw my render methods get called.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Fix BaseView.renderInto() to actually call render().
     
The `renderInto()` helper method handled the DOM manipulation with
aplomb, but in a plot twist, neglected to ever call `render()`. This was
a simple oversight.

Testing Done:
Used `renderInto()` and actually saw my render methods get called.

    

   
  		
  7ed5b43f495cdd2bc789f79d5150d8a0a7ed846e
  David Trowbridge
 




    


    


      
Files


      

 
  
 
 
  src/view.ts
  
 
 
  
   

  
 		


    

    

   

  

 









 

  

   
    

     
      
      src/view.ts
     
    

   
  

 










     

    

   

  

  

   
   Loading...