Summary

Fix BaseView.renderInto() to actually call render().

Review Request #12874 — Created March 8, 2023 and submitted March 9, 2023, 10:14 a.m.

Information

Owner

david

Repository

Spina

Branch

master

Bugs

Depends On

Reviewers

Groups

beanbag-misc

People

Description

The renderInto() helper method handled the DOM manipulation with

aplomb, but in a plot twist, neglected to ever call render(). This was

a simple oversight.

Testing Done

Used renderInto() and actually saw my render methods get called.

Commits

Summary	ID
Fix BaseView.renderInto() to actually call render(). The `renderInto()` helper method handled the DOM manipulation with aplomb, but in a plot twist, neglected to ever call `render()`. This was a simple oversight. Testing Done: Used `renderInto()` and actually saw my render methods get called.	7ed5b43f495cdd2bc789f79d5150d8a0a7ed846e

flake8 passed.

JSHint passed.

Expand All
Collapse All

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (f6fe32f)