Summary

Fix display of existing commits in the new review request UI.

Review Request #12867 — Created March 6, 2023 and submitted March 8, 2023, 8:43 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

A change in our upstream dependencies caused a regression in the display
for existing commits in the new review request UI. The old XHTML-like
<span /> was being interpreted as an unclosed tag, leaking its style
into adjacent elements.

Testing Done

Looked at the new review request UI and saw that existing commits had
the proper blue arrow icon but no big blue text.

Commits

Summary	ID
Fix display of existing commits in the new review request UI. A change in our upstream dependencies caused a regression in the display for existing commits in the new review request UI. The old XHTML-like `<span />` was being interpreted as an unclosed tag, leaking its style into adjacent elements. Testing Done: Looked at the new review request UI and saw that existing commits had the proper blue arrow icon but no big blue text.	42f4211edc75dfd7ee52ea27f051117800d1c901

Summary

Fix display of existing commits in the new review request UI.

A change in our upstream dependencies caused a regression in the display for existing commits in the new review request UI. The old XHTML-like `<span />` was being interpreted as an unclosed tag, leaking its style into adjacent elements. Testing Done: Looked at the new review request UI and saw that existing commits had the proper blue arrow icon but no big blue text.

42f4211edc75dfd7ee52ea27f051117800d1c901

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (f108693)