Summary

Avoid problems when nis is not available on a system.

Review Request #12865 — Created March 3, 2023 and submitted March 6, 2023, 4:16 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The NIS backend assumes that it can safely import the nis module.

However, this isn't always present on Python, and will be removed in

Python 3.13.
This change checks for this, attempting an import and logging if it

fails. The rest of the code will avoid trying to use the module if it's

not available, avoiding a crash.
This was hit in CI, where our Python 3.11 does not appear to ship with

NIS support.

Testing Done

Unit tests pass, with and without nis.

Commits

Summary	ID
Avoid problems when nis is not available on a system. The NIS backend assumes that it can safely import the `nis` module. However, this isn't always present on Python, and will be removed in Python 3.13. This change checks for this, attempting an import and logging if it fails. The rest of the code will avoid trying to use the module if it's not available, avoiding a crash. This was hit in CI, where our Python 3.11 does not appear to ship with NIS support.	1272cc2897ebb9f8018c236820747c3e5fa6ef1e

Summary

Avoid problems when nis is not available on a system.

The NIS backend assumes that it can safely import the `nis` module. However, this isn't always present on Python, and will be removed in Python 3.13. This change checks for this, attempting an import and logging if it fails. The rest of the code will avoid trying to use the module if it's not available, avoiding a crash. This was hit in CI, where our Python 3.11 does not appear to ship with NIS support.

1272cc2897ebb9f8018c236820747c3e5fa6ef1e

Issues

Description	From	Last Updated
Is this related to the nis change? Seems like it snuck in here by accident.	maubin	March 4, 2023, 4:27 p.m.

flake8 passed.

JSHint passed.

reviewboard/scmtools/bzr/__init__.py (Diff revision 1)

The issue has been resolved. Show all issues

Is this related to the nis change? Seems like it snuck in here by accident.

chipx86 March 4, 2023, 4:27 p.m.
```
Oops, that's meant for later. Thanks!
```

Change Summary:

Removed a BZR change that snuck in.

Commits:

	Summary	ID
	Avoid problems when nis is not available on a system. The NIS backend assumes that it can safely import the `nis` module. However, this isn't always present on Python, and will be removed in Python 3.13. This change checks for this, attempting an import and logging if it fails. The rest of the code will avoid trying to use the module if it's not available, avoiding a crash. This was hit in CI, where our Python 3.11 does not appear to ship with NIS support.	b77aea15c524dad7f3e942f693cf7cc2651a9217
	Avoid problems when nis is not available on a system. The NIS backend assumes that it can safely import the `nis` module. However, this isn't always present on Python, and will be removed in Python 3.13. This change checks for this, attempting an import and logging if it fails. The rest of the code will avoid trying to use the module if it's not available, avoiding a crash. This was hit in CI, where our Python 3.11 does not appear to ship with NIS support.	1272cc2897ebb9f8018c236820747c3e5fa6ef1e

Diff:

Revision 2 (+90 -8)

Show changes

	reviewboard/accounts/backends/nis.py
	reviewboard/accounts/tests/test_nis_auth_backend.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (19826c7)