Summary

Avoid triggering Pipeline when running unit tests.

Review Request #12862 — Created March 2, 2023 and submitted March 2, 2023, 4:55 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

When rendering full pages in unit tests, we were triggering Pipeline's
media compilation. This wasn't a problem before, because we had overridden
the list of Pipeline compilers, but we now hard-code Rollup if we opt in.
Rollup ends up triggering some long compilations in this environment, and
potentially was triggering some bad behavior somewhere, as it was resulting
in some stalled tests that had to be force-killed.

We now skip Pipeline entirely when running unit tests.

Testing Done

All unit tests pass.

Commits

Summary	ID
Avoid triggering Pipeline when running unit tests. When rendering full pages in unit tests, we were triggering Pipeline's media compilation. This has been happening for probably years now, but some of the new static media compilation with Rollup was a bit slow in this setup, and potentially was triggering some bad behavior somewhere, as it was resulting in some stalled tests. We now skip Pipeline entirely when running unit tests.	79608c178f801da8fc5d953638dc122532e734bf

Summary

Avoid triggering Pipeline when running unit tests.

When rendering full pages in unit tests, we were triggering Pipeline's media compilation. This has been happening for probably years now, but some of the new static media compilation with Rollup was a bit slow in this setup, and potentially was triggering some bad behavior somewhere, as it was resulting in some stalled tests. We now skip Pipeline entirely when running unit tests.

79608c178f801da8fc5d953638dc122532e734bf

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Description:

		When rendering full pages in unit tests, we were triggering Pipeline's
~		media compilation. This has been happening for probably years now, but
~		some of the new static media compilation with Rollup was a bit slow in
~		this setup, and potentially was triggering some bad behavior somewhere,
~		as it was resulting in some stalled tests.
	~	media compilation. This wasn't a problem before, because we had overridden
	~	the list of Pipeline compilers, but we now hard-code Rollup if we opt in.
	~	Rollup ends up triggering some long compilations in this environment, and
	~	potentially was triggering some bad behavior somewhere, as it was resulting
	+	in some stalled tests that had to be force-killed.

		We now skip Pipeline entirely when running unit tests.

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (80adcb5)