flake8
passed.
JSHint
passed.
Avoid triggering Pipeline when running unit tests.
Review Request #12862 — Created March 2, 2023 and submitted
When rendering full pages in unit tests, we were triggering Pipeline's
media compilation. This wasn't a problem before, because we had overridden
the list of Pipeline compilers, but we now hard-code Rollup if we opt in.
Rollup ends up triggering some long compilations in this environment, and
potentially was triggering some bad behavior somewhere, as it was resulting
in some stalled tests that had to be force-killed.We now skip Pipeline entirely when running unit tests.
All unit tests pass.
| Summary | ID |
|---|---|
| 79608c178f801da8fc5d953638dc122532e734bf |
- Description:
-
When rendering full pages in unit tests, we were triggering Pipeline's
~ media compilation. This has been happening for probably years now, but ~ some of the new static media compilation with Rollup was a bit slow in ~ this setup, and potentially was triggering some bad behavior somewhere, ~ as it was resulting in some stalled tests. ~ media compilation. This wasn't a problem before, because we had overridden ~ the list of Pipeline compilers, but we now hard-code Rollup if we opt in. ~ Rollup ends up triggering some long compilations in this environment, and ~ potentially was triggering some bad behavior somewhere, as it was resulting + in some stalled tests that had to be force-killed. We now skip Pipeline entirely when running unit tests.