Improve performance of checking whether diffsets exist.

Review Request #12853 — Created Feb. 28, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

Some review request actions need to check whether the current review
request has any diffsets. This was initially done by checking directly
on the diffset history, but there are some shortcuts we can take in this
computation based on various caches. This change adds a new
has_diffsets property for this purpose.

Ran unit tests.

Summary ID
Improve performance of checking whether diffsets exist.
Some review request actions need to check whether the current review request has any diffsets. This was initially done by checking directly on the diffset history, but there are some shortcuts we can take in this computation based on various caches. This change adds a new `has_diffsets` property for this purpose. Testing Done: Ran unit tests.
f08dd3da18e5205b353472879d4159bf653bcbff
Description From Last Updated

local variable 'diffsets' is assigned to but never used Column: 9 Error code: F841

reviewbotreviewbot

No period here.

chipx86chipx86
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

david
maubin
  1. Ship It!
  2. 
      
chipx86
  1. Looks great!

  2. No period here.

  3. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (44ca9b3)
Loading...