Summary:

Improve performance of checking whether diffsets exist.

Review Request #12853 — Created Feb. 28, 2023 and submitted March 2, 2023, 8:55 a.m.

Information
Owner:	david
Repository:	Review Board
Branch:	release-6.x
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

Some review request actions need to check whether the current review
request has any diffsets. This was initially done by checking directly
on the diffset history, but there are some shortcuts we can take in this
computation based on various caches. This change adds a new
has_diffsets property for this purpose.

Testing Done

Ran unit tests.

Commits

Summary
	Improve performance of checking whether diffsets exist.

Screenshots

Issues

Description	From	Last Updated
local variable 'diffsets' is assigned to but never used Column: 9 Error code: F841	reviewbot	Feb. 28, 2023, 6:08 p.m.
No period here.	chipx86	March 2, 2023, 8:54 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/tests/test_review_request.py (Diff revision 1)

Show all issues

local variable 'diffsets' is assigned to but never used

Column: 9
Error code: F841

Commits:

	Summary
-		Improve performance of checking whether diffsets exist.
+		Improve performance of checking whether diffsets exist.

Diff:

Revision 2 (+272 -8)

Show changes

	reviewboard/reviews/actions.py
	reviewboard/reviews/models/review_request.py
	reviewboard/reviews/tests/test_review_request.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Looks great!
```
reviewboard/reviews/models/review_request.py (Diff revision 2)
Show all issues
```
No period here.
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (44ca9b3)