Summary

Improve performance of checking whether diffsets exist.

Review Request #12853 — Created Feb. 28, 2023 and submitted March 2, 2023, 8:55 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Some review request actions need to check whether the current review
request has any diffsets. This was initially done by checking directly
on the diffset history, but there are some shortcuts we can take in this
computation based on various caches. This change adds a new
has_diffsets property for this purpose.

Testing Done

Ran unit tests.

Commits

Summary	ID
Improve performance of checking whether diffsets exist. Some review request actions need to check whether the current review request has any diffsets. This was initially done by checking directly on the diffset history, but there are some shortcuts we can take in this computation based on various caches. This change adds a new `has_diffsets` property for this purpose. Testing Done: Ran unit tests.	f08dd3da18e5205b353472879d4159bf653bcbff

Summary

Improve performance of checking whether diffsets exist.

Some review request actions need to check whether the current review request has any diffsets. This was initially done by checking directly on the diffset history, but there are some shortcuts we can take in this computation based on various caches. This change adds a new `has_diffsets` property for this purpose. Testing Done: Ran unit tests.

f08dd3da18e5205b353472879d4159bf653bcbff

Issues

Description	From	Last Updated
local variable 'diffsets' is assigned to but never used Column: 9 Error code: F841	reviewbot	Feb. 28, 2023, 6:08 p.m.
No period here.	chipx86	March 2, 2023, 8:54 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/tests/test_review_request.py (Diff revision 1)
The issue has been dropped. Show all issues
```
local variable 'diffsets' is assigned to but never used

Column: 9
Error code: F841
```

Commits:

	Summary	ID
	Improve performance of checking whether diffsets exist. Some review request actions need to check whether the current review request has any diffsets. This was initially done by checking directly on the diffset history, but there are some shortcuts we can take in this computation based on various caches. This change adds a new `has_diffsets` property for this purpose. Testing Done: Ran unit tests.	3fa34899e13e37db206a782cd37678ea172bd54a
	Improve performance of checking whether diffsets exist. Some review request actions need to check whether the current review request has any diffsets. This was initially done by checking directly on the diffset history, but there are some shortcuts we can take in this computation based on various caches. This change adds a new `has_diffsets` property for this purpose. Testing Done: Ran unit tests.	f08dd3da18e5205b353472879d4159bf653bcbff

Diff:

Revision 2 (+272 -8)

Show changes

	reviewboard/reviews/actions.py
	reviewboard/reviews/models/review_request.py
	reviewboard/reviews/tests/test_review_request.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Looks great!
```
reviewboard/reviews/models/review_request.py (Diff revision 2)
The issue has been resolved. Show all issues
```
No period here.
```

Status:: Completed
Change Summary:: Pushed to release-6.x (44ca9b3)