Summary

Fix image collection and processing in image srcsets.

Review Request #12851 — Created Feb. 27, 2023 and submitted Feb. 28, 2023, 5:14 p.m.

Information

Owner

chipx86

Repository

beanbag-docutils

Branch

master

Bugs

Depends On

Reviewers

Groups

beanbag-misc

People

Description

The new support for image srcsets had issues with generated filenames
when auto-scanning for multi-DPI images, and didn't copy them to the
destination.

This fixes both those issues, ensuring we can build documentation
reliably with multi-DPI images in all situations.

Testing Done

Unit tests passed.

Built the Review Board documentation and verified that all available
multi-DPI images were copied to the destination and included in the
page.

Commits

Summary	ID
Fix image collection and processing in image srcsets. The new support for image srcsets had issues with generated filenames when auto-scanning for multi-DPI images, and didn't copy them to the destination. This fixes both those issues, ensuring we can build documentation reliably with multi-DPI images in all situations.	d73727171ab9e9fd010dbd44091fbfd99b2556d7

Issues

Description	From	Last Updated
undefined name 'List' Column: 5 Error code: F821	reviewbot	Feb. 27, 2023, 8:35 p.m.

flake8 failed.

JSHint passed.

flake8

beanbag_docutils/sphinx/ext/image_srcsets.py (Diff revision 1)
The issue has been resolved. Show all issues
```
undefined name 'List'

Column: 5
Error code: F821
```

Change Summary:

Added a missing import needed for type checking.

Commits:

	Summary	ID
	Fix image collection and processing in image srcsets. The new support for image srcsets had issues with generated filenames when auto-scanning for multi-DPI images, and didn't copy them to the destination. This fixes both those issues, ensuring we can build documentation reliably with multi-DPI images in all situations.	f1f7b1b1b195b32f5d4963cbc7a5e38ebc719f02
	Fix image collection and processing in image srcsets. The new support for image srcsets had issues with generated filenames when auto-scanning for multi-DPI images, and didn't copy them to the destination. This fixes both those issues, ensuring we can build documentation reliably with multi-DPI images in all situations.	d73727171ab9e9fd010dbd44091fbfd99b2556d7

Diff:

Revision 2 (+136 -36)

Show changes

beanbag_docutils/sphinx/ext/image_srcsets.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

Status: Closed (submitted)

Change Summary:

Pushed to master (e94bfd6)