Summary

Fix post-commit UI for small Mercurial repositories.

Review Request #12843 — Created Feb. 24, 2023 and submitted Feb. 26, 2023, 3:18 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change fixes all affected backends to convert the 000 commit to a
proper empty string.

Testing Done


Loaded the /r/new/ UI for a tiny Mercurial repository and saw that it

  no longer made infinite requests for commits.
Ran unit tests.

Commits

Summary	ID
Fix post-commit UI for small Mercurial repositories. The way that the initial commit was represented when fetching lists of commits for Mercurial repositories wasn't correct, reporting an ID of 40 consecutive zeros, instead of an empty parent ID. The result of this is that when the "New Review Request" UI hit the end of the commit list, it would end up in an infinite loop requesting new commits starting at `00000...`. This change fixes all affected backends to convert the 000 commit to a proper empty string. Testing Done: - Loaded the /r/new/ UI for a tiny Mercurial repository and saw that it no longer made infinite requests for commits. - Ran unit tests.	635acf2e646dc0681c4acd39957d3e0cb569c5d9

Summary

Fix post-commit UI for small Mercurial repositories.

The way that the initial commit was represented when fetching lists of commits for Mercurial repositories wasn't correct, reporting an ID of 40 consecutive zeros, instead of an empty parent ID. The result of this is that when the "New Review Request" UI hit the end of the commit list, it would end up in an infinite loop requesting new commits starting at `00000...`. This change fixes all affected backends to convert the 000 commit to a proper empty string. Testing Done: - Loaded the /r/new/ UI for a tiny Mercurial repository and saw that it no longer made infinite requests for commits. - Ran unit tests.

635acf2e646dc0681c4acd39957d3e0cb569c5d9

Issues

Description	From	Last Updated
Can we use a constant for this, so we always have something clear to reference? Alternatively, since we perform this …	chipx86	Feb. 24, 2023, 6:34 p.m.
This can be one line now.	chipx86	Feb. 24, 2023, 6:34 p.m.
Here too.	chipx86	Feb. 24, 2023, 6:34 p.m.

flake8 passed.

JSHint passed.

reviewboard/scmtools/hg.py (Diff revision 1)

The issue has been resolved. Show all issues

Can we use a constant for this, so we always have something clear to reference?
Alternatively, since we perform this same logic in many places, maybe it'd be better to have a normalize function for this.

reviewboard/scmtools/tests/test_hg.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This can be one line now.
```
reviewboard/scmtools/tests/test_hg.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Here too.
```

Commits:

	Summary	ID
	Fix post-commit UI for small Mercurial repositories. The way that the initial commit was represented when fetching lists of commits for Mercurial repositories wasn't correct, reporting an ID of 40 consecutive zeros, instead of an empty parent ID. The result of this is that when the "New Review Request" UI hit the end of the commit list, it would end up in an infinite loop requesting new commits starting at `00000...`. This change fixes all affected backends to convert the 000 commit to a proper empty string. Testing Done: - Loaded the /r/new/ UI for a tiny Mercurial repository and saw that it no longer made infinite requests for commits. - Ran unit tests.	2c257cb38b87a5f56d367045540a08616b8663a2
	Fix post-commit UI for small Mercurial repositories. The way that the initial commit was represented when fetching lists of commits for Mercurial repositories wasn't correct, reporting an ID of 40 consecutive zeros, instead of an empty parent ID. The result of this is that when the "New Review Request" UI hit the end of the commit list, it would end up in an infinite loop requesting new commits starting at `00000...`. This change fixes all affected backends to convert the 000 commit to a proper empty string. Testing Done: - Loaded the /r/new/ UI for a tiny Mercurial repository and saw that it no longer made infinite requests for commits. - Ran unit tests.	635acf2e646dc0681c4acd39957d3e0cb569c5d9

Diff:

Revision 2 (+34 -20)

Show changes

	reviewboard/scmtools/hg.py
	reviewboard/scmtools/tests/test_hg.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (6849020)