I'm on the fence about whether we should have a banner for this. I can see it as being useful, but since there's not much information you can get from it and there's no interactivity, having it persistent on the screen may be a waste of space. Think netbooks. Perhaps we should have this as just a thing on the review request box somewhere. Will need to think about it some more but we should play with ideas here.

This should be in em, and will need to be tested with different font sizes, browser widths, and zoom levels.

Not sure we really want to hard-code this though. We may want to stuff both banners inside of one container that's aligned to the very top instead.

Can just be 3em.

Should be on one line.

Can combine these.

Should wrap to < 80 characters. Might want to split this into two lines.

Also, should be a blank line before the following if statement.

I don't know that we need to call list(). It's more efficient to just keep it an iterator as long as possible.

Should also be split up.

Same comment about list()

Should be in alphabetical order.

No space before :

The "," should be right up against the preceeding username.

test

Could, but then we have a screen width issue.

What I'd rather see is something in one of the bottom corners (say, the right, though we'll need to make sure it plays well with the update notifications). Something the size of a tooltip, perhaps, that just says "4 people are reviewing this change." or something.

However, again, it may not be useful enough to persist on the screen. I'd like to know what other people think there. It could just be a small, thin banner sitting right above the review request box.

Right here.

I like the new look. The padding should be more consistent with other boxes, but I think this looks much better.

check`1

ppppp

pp

ppppppppppppppp

Sorry for the delays in these. Busy time of the year.

While most of this looks good, there's a lot of style changes made to existing code that I want reverted. Mainly lines that were removed for no reason. Also, lots of trailing whitespace. I'd like to see these fixed up before it goes in.

Thanks!

This line shouldn't be removed.

All lowercase hex codes here.

Two blank lines here instead of one.

Don't remove this line.

Don't remove this line.

Trailing whitespace should be removed.

Probably should just be "get_pending_reviews".

Should end with a period. Also, "ordered by user"

Trailing whitespace.

Don't delete this line.

Don't delete this line.

get_pending_reviews

Should be on one line.

Trailing whitespace.

Trailing whitespace.

Don't delete this line.

Should be inserted alphabetically in the list of variables. Should be "pending_reviews" though.

Same here.

Unnecessary change. Should revert this.

This is never dynamically shown. Instead of changing the visibility with CSS, just wrap the entire thing in an {% if %}

Bad combination of spaces and tabs.

Also, the method for indenting tags should be:

{% for review in pending_reviews %}
{%  if forloop..... %}
...
{%  endif %}
{% endfor %}

{{review.user|user_displayname}}. No spaces.

Revert this change.