Split up extensions/hooks.py

Review Request #12837 — Created Feb. 23, 2023 and submitted — Latest diff uploaded

Information

Review Board
release-6.x

Reviewers

hooks.py was getting very large and unwieldy. This change splits it up
into a bunch of individual files, with an index for forwarding
imports.

This does not make any changes to the hook implementations except for
adding a couple is not None assertions to satisfy static type
checkers. I'm planning on following this up later with a change to add
typing to these.

  • Ran unit tests.
  • Built codebase docs and checked output.

Diff Revision 1

This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

orig
1
2

Commits

First Last Summary ID Author
Split up extensions/hooks.py
`hooks.py` was getting very large and unwieldy. This change splits it up into a bunch of individual files, with an index for forwarding imports. This does not make any changes to the hook implementations except for adding a couple `is not None` assertions to satisfy static type checkers. I'm planning on following this up later with a change to add typing to these. Testing Done: - Ran unit tests. - Built codebase docs and checked output.
c05c2350af53a400291d6d8e763eaf2b30345ecf David Trowbridge
reviewboard/extensions/hooks.py
reviewboard/extensions/hooks/__init__.py
reviewboard/extensions/hooks/account_page.py
reviewboard/extensions/hooks/actions.py
reviewboard/extensions/hooks/admin_widget.py
reviewboard/extensions/hooks/api_extra_data_access.py
reviewboard/extensions/hooks/auth_backend.py
reviewboard/extensions/hooks/avatar_service.py
reviewboard/extensions/hooks/comment_detail_display.py
reviewboard/extensions/hooks/dashboard.py
reviewboard/extensions/hooks/email.py
reviewboard/extensions/hooks/fields.py
reviewboard/extensions/hooks/file_attachment_thumbnail.py
reviewboard/extensions/hooks/filediff_acl.py
reviewboard/extensions/hooks/hosting_service.py
reviewboard/extensions/hooks/integration.py
reviewboard/extensions/hooks/navigation_bar.py
reviewboard/extensions/hooks/review_request_approval.py
reviewboard/extensions/hooks/review_ui.py
reviewboard/extensions/hooks/scmtool.py
reviewboard/extensions/hooks/user_infobox.py
reviewboard/extensions/hooks/webapi_capabilities.py
reviewboard/extensions/tests/test_action_hooks.py
Loading...