Split up extensions/hooks.py

Review Request #12837 — Created Feb. 23, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

hooks.py was getting very large and unwieldy. This change splits it up
into a bunch of individual files, with an index for forwarding
imports.

This does not make any changes to the hook implementations except for
adding a couple is not None assertions to satisfy static type
checkers. I'm planning on following this up later with a change to add
typing to these.

  • Ran unit tests.
  • Built codebase docs and checked output.
Summary ID
Split up extensions/hooks.py
`hooks.py` was getting very large and unwieldy. This change splits it up into a bunch of individual files, with an index for forwarding imports. This does not make any changes to the hook implementations except for adding a couple `is not None` assertions to satisfy static type checkers. I'm planning on following this up later with a change to add typing to these. Testing Done: - Ran unit tests. - Built codebase docs and checked output.
a8f927c75ef56fc8bb8c79a7ea0fda3909f4b993
Description From Last Updated

Sorry, I know there's a lot of files, but can you add a from __future__ import annotations to any of …

chipx86chipx86

line too long (86 > 79 characters) Column: 80 Error code: E501

reviewbotreviewbot

line too long (98 > 79 characters) Column: 80 Error code: E501

reviewbotreviewbot

line too long (82 > 79 characters) Column: 80 Error code: E501

reviewbotreviewbot

line too long (86 > 79 characters) Column: 80 Error code: E501

reviewbotreviewbot

line too long (98 > 79 characters) Column: 80 Error code: E501

reviewbotreviewbot

line too long (82 > 79 characters) Column: 80 Error code: E501

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
  1. 
      
  2. Sorry, I know there's a lot of files, but can you add a from __future__ import annotations to any of these that use type annotations?

    1. I'm going to just add it to everything because we will eventually add annotations to all this.

  3. 
      
david
Review request changed

Commits:

Summary ID
Split up extensions/hooks.py
`hooks.py` was getting very large and unwieldy. This change splits it up into a bunch of individual files, with an index for forwarding imports. This does not make any changes to the hook implementations except for adding a couple `is not None` assertions to satisfy static type checkers. I'm planning on following this up later with a change to add typing to these. Testing Done: - Ran unit tests. - Built codebase docs and checked output.
c05c2350af53a400291d6d8e763eaf2b30345ecf
Split up extensions/hooks.py
`hooks.py` was getting very large and unwieldy. This change splits it up into a bunch of individual files, with an index for forwarding imports. This does not make any changes to the hook implementations except for adding a couple `is not None` assertions to satisfy static type checkers. I'm planning on following this up later with a change to add typing to these. Testing Done: - Ran unit tests. - Built codebase docs and checked output.
a8f927c75ef56fc8bb8c79a7ea0fda3909f4b993

Diff:

Revision 2 (+4350 -4028)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

maubin
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (4b1ad72)
Loading...