Summary

Split up extensions/hooks.py

Review Request #12837 — Created Feb. 23, 2023 and submitted March 22, 2023, 9:27 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

hooks.py was getting very large and unwieldy. This change splits it up

into a bunch of individual files, with an index for forwarding

imports.
This does not make any changes to the hook implementations except for

adding a couple is not None assertions to satisfy static type

checkers. I'm planning on following this up later with a change to add

typing to these.

Testing Done


Ran unit tests.
Built codebase docs and checked output.

Commits

Summary	ID
Split up extensions/hooks.py `hooks.py` was getting very large and unwieldy. This change splits it up into a bunch of individual files, with an index for forwarding imports. This does not make any changes to the hook implementations except for adding a couple `is not None` assertions to satisfy static type checkers. I'm planning on following this up later with a change to add typing to these. Testing Done: - Ran unit tests. - Built codebase docs and checked output.	a8f927c75ef56fc8bb8c79a7ea0fda3909f4b993

Summary

Split up extensions/hooks.py

`hooks.py` was getting very large and unwieldy. This change splits it up into a bunch of individual files, with an index for forwarding imports. This does not make any changes to the hook implementations except for adding a couple `is not None` assertions to satisfy static type checkers. I'm planning on following this up later with a change to add typing to these. Testing Done: - Ran unit tests. - Built codebase docs and checked output.

a8f927c75ef56fc8bb8c79a7ea0fda3909f4b993

Issues

Description	From	Last Updated
Sorry, I know there's a lot of files, but can you add a from __future__ import annotations to any of …	chipx86	March 15, 2023, 9:12 a.m.
line too long (86 > 79 characters) Column: 80 Error code: E501	reviewbot	Feb. 23, 2023, 11:44 a.m.
line too long (98 > 79 characters) Column: 80 Error code: E501	reviewbot	Feb. 23, 2023, 11:44 a.m.
line too long (82 > 79 characters) Column: 80 Error code: E501	reviewbot	Feb. 23, 2023, 11:44 a.m.
line too long (86 > 79 characters) Column: 80 Error code: E501	reviewbot	March 15, 2023, 3:27 p.m.
line too long (98 > 79 characters) Column: 80 Error code: E501	reviewbot	March 15, 2023, 3:27 p.m.
line too long (82 > 79 characters) Column: 80 Error code: E501	reviewbot	March 15, 2023, 3:27 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/extensions/hooks/api_extra_data_access.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (86 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/extensions/hooks/api_extra_data_access.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (98 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/extensions/hooks/email.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (82 > 79 characters)

Column: 80
Error code: E501
```

The issue has been resolved. Show all issues

Sorry, I know there's a lot of files, but can you add a from __future__ import annotations to any of these that use type annotations?

david March 15, 2023, 9:11 a.m.

I'm going to just add it to everything because we will eventually add annotations to all this.

Commits:

	Summary	ID
	Split up extensions/hooks.py `hooks.py` was getting very large and unwieldy. This change splits it up into a bunch of individual files, with an index for forwarding imports. This does not make any changes to the hook implementations except for adding a couple `is not None` assertions to satisfy static type checkers. I'm planning on following this up later with a change to add typing to these. Testing Done: - Ran unit tests. - Built codebase docs and checked output.	c05c2350af53a400291d6d8e763eaf2b30345ecf
	Split up extensions/hooks.py `hooks.py` was getting very large and unwieldy. This change splits it up into a bunch of individual files, with an index for forwarding imports. This does not make any changes to the hook implementations except for adding a couple `is not None` assertions to satisfy static type checkers. I'm planning on following this up later with a change to add typing to these. Testing Done: - Ran unit tests. - Built codebase docs and checked output.	a8f927c75ef56fc8bb8c79a7ea0fda3909f4b993

Diff:

Revision 2 (+4350 -4028)

Show changes

	reviewboard/extensions/hooks.py
	reviewboard/extensions/hooks/__init__.py
	reviewboard/extensions/hooks/account_page.py
	reviewboard/extensions/hooks/actions.py
	reviewboard/extensions/hooks/admin_widget.py
	reviewboard/extensions/hooks/api_extra_data_access.py
	reviewboard/extensions/hooks/auth_backend.py
	reviewboard/extensions/hooks/avatar_service.py
	15 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/extensions/hooks/api_extra_data_access.py (Diff revision 2)
The issue has been dropped. Show all issues
```
line too long (86 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/extensions/hooks/api_extra_data_access.py (Diff revision 2)
The issue has been dropped. Show all issues
```
line too long (98 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/extensions/hooks/email.py (Diff revision 2)
The issue has been dropped. Show all issues
```
line too long (82 > 79 characters)

Column: 80
Error code: E501
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-6.x (4b1ad72)