Port MenuView to TypeScript and spina.

 






 

 


  Review Request #12827
  —
  Created Feb. 7, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-6.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change ports the MenuView over to TypeScript and spina. This is

relatively straightforward.


As part of this, the ui bundle has been changed to load on all pages

instead of just ones inheriting from reviewable_base.html

 








  


 
 

  
    

  • Tested various places that used MenuView (menu actions, menu buttons in
    
  banners/dialogs).
    • 

  • Ran js-tests.
    • 


 







 









 





  








 




 







   

    
    
Diff Revision 2 (Latest)



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Port MenuView to TypeScript and spina.
     
This change ports the MenuView over to TypeScript and spina. This is
relatively straightforward.

As part of this, the `ui` bundle has been changed to load on all pages
instead of just ones inheriting from reviewable_base.html

Testing Done:
- Tested various places that used MenuView (menu actions, menu buttons in
  banners/dialogs).
- Ran js-tests.

    

   
  		
  fa42e66f849bab28fadb88dd4a1db2a9eaf39649
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/staticbundles.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/actions/views/menuActionView.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/ui/index.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/ui/views/menuButtonView.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/ui/views/menuView.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/ui/views/tests/menuViewTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/templates/base.html
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/templates/reviews/reviewable_base.html
     
    

   
  

 










     

    

   

  

  

   
   Loading...