Summary

Port MenuView to TypeScript and spina.

Review Request #12827 — Created Feb. 7, 2023 and submitted Feb. 27, 2023, 8:28 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change ports the MenuView over to TypeScript and spina. This is
relatively straightforward.

As part of this, the ui bundle has been changed to load on all pages
instead of just ones inheriting from reviewable_base.html

Testing Done


Tested various places that used MenuView (menu actions, menu buttons in

  banners/dialogs).
Ran js-tests.

Commits

Summary	ID
Port MenuView to TypeScript and spina. This change ports the MenuView over to TypeScript and spina. This is relatively straightforward. As part of this, the `ui` bundle has been changed to load on all pages instead of just ones inheriting from reviewable_base.html Testing Done: - Tested various places that used MenuView (menu actions, menu buttons in banners/dialogs). - Ran js-tests.	fa42e66f849bab28fadb88dd4a1db2a9eaf39649

Issues

Description	From	Last Updated
I don't remember where we landed on this from another review, but do we want to split this into two …	chipx86	Feb. 22, 2023, 8:21 a.m.
Let's alphabetize by import module.	chipx86	Feb. 22, 2023, 8:21 a.m.
Can we type and document these using the interface?	chipx86	Feb. 22, 2023, 8:23 a.m.
Does TypeScript let us use a trailing comma for the last item?	chipx86	Feb. 22, 2023, 8:23 a.m.
Missing Version Added.	chipx86	Feb. 22, 2023, 8:28 a.m.
The summary should be on its own line.	chipx86	Feb. 22, 2023, 8:28 a.m.
Missing a semicolon.	chipx86	Feb. 22, 2023, 8:28 a.m.
Do subclasses need to set these? If not, we can avoid all this and use the proper elements in the …	chipx86	Feb. 22, 2023, 8:31 a.m.
Let's move private after public.	chipx86	Feb. 22, 2023, 8:29 a.m.
Should we make this an interface?	chipx86	Feb. 22, 2023, 8:29 a.m.
The <cast>... syntax is considered deprecated. We should use ... as type instead.	chipx86	Feb. 22, 2023, 8:29 a.m.
Casting should use ... as ... syntax.	chipx86	Feb. 22, 2023, 8:29 a.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/common/actions/views/menuActionView.ts (Diff revision 1)

Show all issues

I don't remember where we landed on this from another review, but do we want to split this into two import groups, from the perspective of this bundle?

reviewboard/static/rb/js/ui/index.ts (Diff revision 1)
Show all issues
```
Let's alphabetize by import module.
```

reviewboard/static/rb/js/ui/views/menuButtonView.ts (Diff revision 1)

Show all issues

Can we type and document these using the interface?

reviewboard/static/rb/js/ui/views/menuView.ts (Diff revision 1)
Show all issues
```
Does TypeScript let us use a trailing comma for the last item?
```
reviewboard/static/rb/js/ui/views/menuView.ts (Diff revision 1)
Show all issues
```
Missing Version Added.
```
reviewboard/static/rb/js/ui/views/menuView.ts (Diff revision 1)
Show all issues
```
The summary should be on its own line.
```
reviewboard/static/rb/js/ui/views/menuView.ts (Diff revision 1)
Show all issues
```
Missing a semicolon.
```

reviewboard/static/rb/js/ui/views/menuView.ts (Diff revision 1)

Show all issues

Do subclasses need to set these? If not, we can avoid all this and use the proper elements in the base class setup.

reviewboard/static/rb/js/ui/views/menuView.ts (Diff revision 1)

Show all issues

Let's move private after public.

reviewboard/static/rb/js/ui/views/menuView.ts (Diff revision 1)
Show all issues
```
Should we make this an interface?
```

reviewboard/static/rb/js/ui/views/menuView.ts (Diff revision 1)

Show all issues

The <cast>... syntax is considered deprecated. We should use ... as type instead.

reviewboard/static/rb/js/ui/views/menuView.ts (Diff revision 1)
Show all issues
```
Casting should use ... as ... syntax.
```

Commits:

	Summary	ID
	Port MenuView to TypeScript and spina. This change ports the MenuView over to TypeScript and spina. This is relatively straightforward. As part of this, the `ui` bundle has been changed to load on all pages instead of just ones inheriting from reviewable_base.html Testing Done: - Tested various places that used MenuView (menu actions, menu buttons in banners/dialogs). - Ran js-tests.	e76cf5734d1abd39f1c8a7f3d02266e663696192
	Port MenuView to TypeScript and spina. This change ports the MenuView over to TypeScript and spina. This is relatively straightforward. As part of this, the `ui` bundle has been changed to load on all pages instead of just ones inheriting from reviewable_base.html Testing Done: - Tested various places that used MenuView (menu actions, menu buttons in banners/dialogs). - Ran js-tests.	fa42e66f849bab28fadb88dd4a1db2a9eaf39649

Diff:

Revision 2 (+678 -488)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/actions/views/menuActionView.ts
	reviewboard/static/rb/js/ui/index.ts
	reviewboard/static/rb/js/ui/views/menuButtonView.ts
	reviewboard/static/rb/js/ui/views/menuView.es6.js
	reviewboard/static/rb/js/ui/views/tests/menuViewTests.es6.js
	reviewboard/templates/base.html
	reviewboard/templates/reviews/reviewable_base.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (7eb202e)