flake8
passed.
JSHint
passed.
Port MenuView to TypeScript and spina.
Review Request #12827 — Created Feb. 7, 2023 and submitted
| Information | |
|---|---|
| david | |
| Review Board | |
| release-6.x | |
| Reviewers | |
| reviewboard | |
This change ports the MenuView over to TypeScript and spina. This is
relatively straightforward.As part of this, the
uibundle has been changed to load on all pages
instead of just ones inheriting from reviewable_base.html
- Tested various places that used MenuView (menu actions, menu buttons in
banners/dialogs). - Ran js-tests.
| Summary | |
|---|---|
| Description | From | Last Updated |
|---|---|---|
|
I don't remember where we landed on this from another review, but do we want to split this into two … |
 chipx86
|
|
|
Let's alphabetize by import module. |
chipx86
|
|
|
Can we type and document these using the interface? |
chipx86
|
|
|
Does TypeScript let us use a trailing comma for the last item? |
chipx86
|
|
|
Missing Version Added. |
chipx86
|
|
|
The summary should be on its own line. |
chipx86
|
|
|
Missing a semicolon. |
chipx86
|
|
|
Do subclasses need to set these? If not, we can avoid all this and use the proper elements in the … |
chipx86
|
|
|
Let's move private after public. |
chipx86
|
|
|
Should we make this an interface? |
chipx86
|
|
|
The <cast>... syntax is considered deprecated. We should use ... as type instead. |
chipx86
|
|
|
Casting should use ... as ... syntax. |
chipx86
|
-
-
reviewboard/static/rb/js/common/actions/views/menuActionView.ts (Diff revision 1) I don't remember where we landed on this from another review, but do we want to split this into two import groups, from the perspective of this bundle?
-
-
reviewboard/static/rb/js/ui/views/menuButtonView.ts (Diff revision 1) Can we type and document these using the interface?
-
reviewboard/static/rb/js/ui/views/menuView.ts (Diff revision 1) Does TypeScript let us use a trailing comma for the last item?
-
-
reviewboard/static/rb/js/ui/views/menuView.ts (Diff revision 1) The summary should be on its own line.
-
-
reviewboard/static/rb/js/ui/views/menuView.ts (Diff revision 1) Do subclasses need to set these? If not, we can avoid all this and use the proper elements in the base class setup.
-
-
-
reviewboard/static/rb/js/ui/views/menuView.ts (Diff revision 1) The
<cast>...syntax is considered deprecated. We should use... as typeinstead. -
reviewboard/static/rb/js/ui/views/menuView.ts (Diff revision 1) Casting should use
... as ...syntax.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+678 -488) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.