Summary

Add url_name parameter to TestCase.create_http_request

Review Request #12823 — Created Feb. 3, 2023 and submitted Feb. 22, 2023, 8:16 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

In order to be able to use create_http_request for tests related to

URL names (for example, extensions or actions that use apply_to), we

need to set the URL name on the ResolverMatch. This adds a parameter

to the test helper to let us set that.
This also fixes up usage with local sites, where we were setting

Request.local_site but not Request._local_site_name.
Testing Done:

Used in conjunction with other changes.
More testcase

Testing Done

Used in conjunction with other changes.

Commits

Summary	ID
Add url_name parameter to TestCase.create_http_request In order to be able to use `create_http_request` for tests related to URL names (for example, extensions or actions that use `apply_to`), we need to set the URL name on the `ResolverMatch`. This adds a parameter to the test helper to let us set that. This also fixes up usage with local sites, where we were setting `Request.local_site` but not `Request._local_site_name`. Testing Done: Used in conjunction with other changes. More testcase	95a68647b6f5dc2b0023bd1e60f9b323351aae97

Summary

Add url_name parameter to TestCase.create_http_request

In order to be able to use `create_http_request` for tests related to URL names (for example, extensions or actions that use `apply_to`), we need to set the URL name on the `ResolverMatch`. This adds a parameter to the test helper to let us set that. This also fixes up usage with local sites, where we were setting `Request.local_site` but not `Request._local_site_name`. Testing Done: Used in conjunction with other changes. More testcase

95a68647b6f5dc2b0023bd1e60f9b323351aae97

Issues

Description	From	Last Updated
do not assign a lambda expression, use a def Column: 17 Error code: E731	reviewbot	Feb. 3, 2023, 11:27 a.m.
) -> HttpRequest should be on the next line, unindented a level. **kwargs should have a trailing comma.	chipx86	Feb. 3, 2023, 9:39 p.m.
Can you add a Version Added for this, and a Version Changed on the method? Even though they're unit tests, …	chipx86	Feb. 3, 2023, 9:40 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/testing/testcase.py (Diff revision 1)
The issue has been dropped. Show all issues
```
do not assign a lambda expression, use a def

Column: 17
Error code: E731
```

Change Summary:


Fix up warning about lambdas
Fix a bug encountered with reverse URLs when using with_local_site=True

Description:

		In order to be able to use `create_http_request` for tests related to
		URL names (for example, extensions or actions that use `apply_to`), we
		need to set the URL name on the `ResolverMatch`. This adds a parameter
		to the test helper to let us set that.
	+
	+	This also fixes up usage with local sites, where we were setting
	+	`Request.local_site` but not `Request._local_site_name`.
	+
	+	Testing Done:
	+	Used in conjunction with other changes.
	+
	+	More testcase

Commits:

	Summary	ID
	Add url_name parameter to TestCase.create_http_request In order to be able to use `create_http_request` for tests related to URL names (for example, extensions or actions that use `apply_to`), we need to set the URL name on the `ResolverMatch`. This adds a parameter to the test helper to let us set that. Testing Done: Used in conjunction with other changes.	4275a5db3620d1f853f36f8007574d1d6f5cbefa
	Add url_name parameter to TestCase.create_http_request In order to be able to use `create_http_request` for tests related to URL names (for example, extensions or actions that use `apply_to`), we need to set the URL name on the `ResolverMatch`. This adds a parameter to the test helper to let us set that. This also fixes up usage with local sites, where we were setting `Request.local_site` but not `Request._local_site_name`. Testing Done: Used in conjunction with other changes. More testcase	cc0131a8be2f81710643cf96044744ed27704a33

Diff:

Revision 2 (+56 -20)

Show changes

reviewboard/testing/testcase.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/testing/testcase.py (Diff revision 2)

The issue has been resolved. Show all issues

) -> HttpRequest should be on the next line, unindented a level. **kwargs should have a trailing comma.

reviewboard/testing/testcase.py (Diff revision 2)

The issue has been resolved. Show all issues

Can you add a Version Added for this, and a Version Changed on the method?

Even though they're unit tests, this has been very helpful in the past when trying to backport stuff.

Commits:

	Summary	ID
	Add url_name parameter to TestCase.create_http_request In order to be able to use `create_http_request` for tests related to URL names (for example, extensions or actions that use `apply_to`), we need to set the URL name on the `ResolverMatch`. This adds a parameter to the test helper to let us set that. This also fixes up usage with local sites, where we were setting `Request.local_site` but not `Request._local_site_name`. Testing Done: Used in conjunction with other changes. More testcase	cc0131a8be2f81710643cf96044744ed27704a33
	Add url_name parameter to TestCase.create_http_request In order to be able to use `create_http_request` for tests related to URL names (for example, extensions or actions that use `apply_to`), we need to set the URL name on the `ResolverMatch`. This adds a parameter to the test helper to let us set that. This also fixes up usage with local sites, where we were setting `Request.local_site` but not `Request._local_site_name`. Testing Done: Used in conjunction with other changes. More testcase	95a68647b6f5dc2b0023bd1e60f9b323351aae97

Diff:

Revision 3 (+72 -20)

Show changes

reviewboard/testing/testcase.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (ad79fb3)