flake8
-
reviewboard/testing/testcase.py (Diff revision 1) Show all issues
Review Request #12823 — Created Feb. 3, 2023 and submitted
Information | |
---|---|
david | |
Review Board | |
release-6.x | |
Reviewers | |
reviewboard | |
In order to be able to use
create_http_request
for tests related to
URL names (for example, extensions or actions that useapply_to
), we
need to set the URL name on theResolverMatch
. This adds a parameter
to the test helper to let us set that.This also fixes up usage with local sites, where we were setting
Request.local_site
but notRequest._local_site_name
.Testing Done:
Used in conjunction with other changes.More testcase
Used in conjunction with other changes.
Summary | |
---|---|
Description | From | Last Updated |
---|---|---|
do not assign a lambda expression, use a def Column: 17 Error code: E731 |
![]() |
|
) -> HttpRequest should be on the next line, unindented a level. **kwargs should have a trailing comma. |
|
|
Can you add a Version Added for this, and a Version Changed on the method? Even though they're unit tests, … |
|
Description: |
|
||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commits: |
|
||||||||||||||||||||||||||||||||||||
Diff: |
Revision 2 (+56 -20) |
reviewboard/testing/testcase.py (Diff revision 2) |
---|
) -> HttpRequest
should be on the next line, unindented a level.**kwargs
should have a trailing comma.
reviewboard/testing/testcase.py (Diff revision 2) |
---|
Can you add a
Version Added
for this, and aVersion Changed
on the method?Even though they're unit tests, this has been very helpful in the past when trying to backport stuff.
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+72 -20) |