Fish Trophy

maubin got a fish trophy!

Fish Trophy

Fix an improperly declared variable that broke our autocomplete UI.

Review Request #12821 — Created Feb. 1, 2023 and submitted — Latest diff uploaded


Review Board


We have some pretty old 3rd party code for our autocomplete UI that has an
improperly declared variable in one of its for loops, which breaks our
autocomplete UI. This didn't cause any problems in previous Review Board
versions, but with our recent JavaScript upgrades we now bundle in our 3rd
party code by importing straight from node_modules, rather than manually
copying it into our tree. This is most likely what exposed the bug. While we
should ultimately move away from this autocomplete code and replace it with
something more modern, for now we'll just patch it. This change fixes the
improperly declared variable.

Manually tested the autocomplete UI.