Summary

Convert the new RepositoryForm and RepositoryFormView to Spina.

Review Request #12820 — Created Jan. 31, 2023 and updated Feb. 3, 2023, 2:48 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change updates the brand-new in-progress RepositoryForm and

RepositoryFormView classes in JavaScript to use TypeScript and

Spina-based classes instead of Backbone.
This gives us proper type checking for both the model and form, using

interfaces to define available attributes (which also ensures proper

.get() usage on models). It also enables usage of private methods.
Other than porting and documentation, this doesn't fundamentally alter

much of the code. Logic remains the same.
The new code is also now part of the rb/js/admin Rollup bundle, rather

than being listed explicitly in the Pipeline bundle.

Testing Done

Ran through all the various modes in the repository admin form. Didn't
spot any noticeable issues. Verified I was running the new generated
code.

Commits

Summary	ID
Convert the new RepositoryForm and RepositoryFormView to Spina. This change updates the brand-new in-progress `RepositoryForm` and `RepositoryFormView` classes in JavaScript to use TypeScript and Spina-based classes instead of Backbone. This gives us proper type checking for both the model and form, using interfaces to define available attributes (which also ensures proper `.get()` usage on models). It also enables usage of private methods. Other than porting and documentation, this doesn't fundamentally alter much of the code. Logic remains the same. The new code is also now part of the `rb/js/admin` Rollup bundle, rather than being listed explicitly in the Pipeline bundle.	a94b2defd0afd0e20e05cc670ae93240fcb0e3c4

Summary

Convert the new RepositoryForm and RepositoryFormView to Spina.

This change updates the brand-new in-progress `RepositoryForm` and `RepositoryFormView` classes in JavaScript to use TypeScript and Spina-based classes instead of Backbone. This gives us proper type checking for both the model and form, using interfaces to define available attributes (which also ensures proper `.get()` usage on models). It also enables usage of private methods. Other than porting and documentation, this doesn't fundamentally alter much of the code. Logic remains the same. The new code is also now part of the `rb/js/admin` Rollup bundle, rather than being listed explicitly in the Pipeline bundle.

a94b2defd0afd0e20e05cc670ae93240fcb0e3c4

Issues

Description	From	Last Updated
This can be private.	david	Feb. 3, 2023, 2:48 p.m.
This can be private.	david	Feb. 3, 2023, 2:48 p.m.
These could all be private.	david	Feb. 3, 2023, 2:48 p.m.

flake8 passed.

JSHint passed.

Change Summary:

Added the same "Instance variables" marker we use in Python to the TypeScript classes.

Commits:

	Summary	ID
	Convert the new RepositoryForm and RepositoryFormView to Spina. This change updates the brand-new in-progress `RepositoryForm` and `RepositoryFormView` classes in JavaScript to use TypeScript and Spina-based classes instead of Backbone. This gives us proper type checking for both the model and form, using interfaces to define available attributes (which also ensures proper `.get()` usage on models). It also enables usage of private methods. Other than porting and documentation, this doesn't fundamentally alter much of the code. Logic remains the same. The new code is also now part of the `rb/js/admin` Rollup bundle, rather than being listed explicitly in the Pipeline bundle.	0aec77e422ed781444fe58d73e379abfb6e005bd
	Convert the new RepositoryForm and RepositoryFormView to Spina. This change updates the brand-new in-progress `RepositoryForm` and `RepositoryFormView` classes in JavaScript to use TypeScript and Spina-based classes instead of Backbone. This gives us proper type checking for both the model and form, using interfaces to define available attributes (which also ensures proper `.get()` usage on models). It also enables usage of private methods. Other than porting and documentation, this doesn't fundamentally alter much of the code. Logic remains the same. The new code is also now part of the `rb/js/admin` Rollup bundle, rather than being listed explicitly in the Pipeline bundle.	c7dc6a571f003320167a01d5bd511d1ed29736bd

Diff:

Revision 2 (+698 -428)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/admin/index.ts
	reviewboard/static/rb/js/admin/models/repositoryFormModel.es6.js
	reviewboard/static/rb/js/admin/models/tests/repositoryFormModelTests.es6.js
	reviewboard/static/rb/js/admin/views/repositoryFormView.es6.js
	reviewboard/templates/admin/scmtools/repository/change_form.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:


Made fields in the attribute interfaces optional, to ease dynamically building attributes.
Changed some "tool" references to "scmtool", for consistency.

Commits:

	Summary	ID
	Convert the new RepositoryForm and RepositoryFormView to Spina. This change updates the brand-new in-progress `RepositoryForm` and `RepositoryFormView` classes in JavaScript to use TypeScript and Spina-based classes instead of Backbone. This gives us proper type checking for both the model and form, using interfaces to define available attributes (which also ensures proper `.get()` usage on models). It also enables usage of private methods. Other than porting and documentation, this doesn't fundamentally alter much of the code. Logic remains the same. The new code is also now part of the `rb/js/admin` Rollup bundle, rather than being listed explicitly in the Pipeline bundle.	c7dc6a571f003320167a01d5bd511d1ed29736bd
	Convert the new RepositoryForm and RepositoryFormView to Spina. This change updates the brand-new in-progress `RepositoryForm` and `RepositoryFormView` classes in JavaScript to use TypeScript and Spina-based classes instead of Backbone. This gives us proper type checking for both the model and form, using interfaces to define available attributes (which also ensures proper `.get()` usage on models). It also enables usage of private methods. Other than porting and documentation, this doesn't fundamentally alter much of the code. Logic remains the same. The new code is also now part of the `rb/js/admin` Rollup bundle, rather than being listed explicitly in the Pipeline bundle.	a94b2defd0afd0e20e05cc670ae93240fcb0e3c4

Diff:

Revision 3 (+1072 -804)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/admin/index.ts
	reviewboard/static/rb/js/admin/models/repositoryFormModel.ts
	reviewboard/static/rb/js/admin/models/repositoryFormModel.es6.js
	reviewboard/static/rb/js/admin/models/tests/repositoryFormModelTests.es6.js
	reviewboard/static/rb/js/admin/views/repositoryFormView.es6.js
	reviewboard/templates/admin/scmtools/repository/change_form.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Fix it!

reviewboard/static/rb/js/admin/views/repositoryFormView.ts (Diff revision 3)
An issue was opened. Show all issues
```
This can be private.
```
reviewboard/static/rb/js/admin/views/repositoryFormView.ts (Diff revision 3)
An issue was opened. Show all issues
```
This can be private.
```

reviewboard/static/rb/js/admin/views/repositoryFormView.ts (Diff revision 3)

An issue was opened. Show all issues

These could all be private.