Summary

Set default limits for diff sizes and syntax highlighting.

Review Request #12816 — Created Jan. 30, 2023 and submitted Feb. 2, 2023, 2:45 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Now, the diff upload size is set to 2MB as a default, and the syntax
highlighting is set to 20,000 lines.

These will only be set for brand-new installations. Existing installs
will retain any stored settings.

Testing Done

Created a new database, viewed the settings page, and saw the values.

Verified these through siteconfig debug output.

Commits

Summary	ID
Set default limits for diff sizes and syntax highlighting. We have options for controlling the maximum diff upload size, and for setting the threshold of number of lines before syntax highlighting is disabled. However, these were never given reasonable defaults. Now, the diff upload size is set to 2MB as a default, and the syntax highlighting is set to 20,000 lines. These will only be set for brand-new installations. Existing installs will retain any stored settings.	08536f682c0d43bea4c86cc45c71dab3e5689a9b

Summary

Set default limits for diff sizes and syntax highlighting.

We have options for controlling the maximum diff upload size, and for setting the threshold of number of lines before syntax highlighting is disabled. However, these were never given reasonable defaults. Now, the diff upload size is set to 2MB as a default, and the syntax highlighting is set to 20,000 lines. These will only be set for brand-new installations. Existing installs will retain any stored settings.

08536f682c0d43bea4c86cc45c71dab3e5689a9b

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (e476eff)